Cargo.toml

@@ -4,54 +4,52 @@ description = "An emulator for the Virtual Boy."
 repository = "https://git.virtual-boy.com/PVB/lemur"
 publish = false
 license = "MIT"
-version = "0.13.1"
+version = "0.7.3"
 edition = "2024"
 
 [dependencies]
 anyhow = "1"
-atoi = "3"
-audioadapter-buffers = "4"
+atoi = "2"
 atomic = "0.6"
 bitflags = { version = "2", features = ["serde"] }
 bytemuck = { version = "1", features = ["derive"] }
 clap = { version = "4", features = ["derive"] }
-cpal = "0.18"
+cpal = { git = "https://github.com/sidit77/cpal.git", rev = "66ed6be" }
 directories = "6"
-egui = { version = "0.34", features = ["persistence", "serde"] }
-egui_extras = { version = "0.34", features = ["image"] }
-egui-notify = "0.22"
-egui-winit = "0.34"
-egui-wgpu = { version = "0.34", features = ["winit"] }
+egui = { version = "0.32", features = ["serde"] }
+egui_extras = { version = "0.32", features = ["image"] }
+egui-notify = "0.20"
+egui-winit = "0.32"
+egui-wgpu = { version = "0.32", features = ["winit"] }
 fxprof-processed-profile = "0.8"
 fixed = { version = "1.28", features = ["num-traits"] }
 gilrs = { version = "0.11", features = ["serde-serialize"] }
-gimli = "0.34"
+gimli = "0.32"
 hex = "0.4"
 image = { version = "0.25", default-features = false, features = ["png"] }
-itertools = "0.15"
+itertools = "0.14"
 normpath = "1"
-notify = "8"
 num-derive = "0.4"
 num-traits = "0.2"
-object = "0.39"
-oneshot = { version = "0.2", features = ["async", "std"] }
-pollster = "1"
-rand = "0.10"
-rfd = "0.17"
+object = "0.37"
+oneshot = "0.1"
+pollster = "0.4"
+rand = "0.9"
+rfd = { version = "0.15", default-features = false, features = ["xdg-portal", "async-std"]}
 rtrb = "0.3"
-rubato = "4"
+rubato = "0.16"
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
-thread-priority = "3"
+thread-priority = "2"
 tokio = { version = "1", features = ["io-util", "macros", "net", "rt", "sync", "time"] }
-tracing = { version = "0.1", features = ["release_max_level_debug"] }
+tracing = { version = "0.1", features = ["release_max_level_info"] }
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
-wgpu = { version = "29", features = ["serde"] }
+wgpu = "25"
 wholesym = "0.8"
 winit = { version = "0.30", features = ["serde"] }
 
 [target.'cfg(windows)'.dependencies]
-windows = { version = "0.62", features = ["Win32_System_Threading"] }
+windows = { version = "0.61", features = ["Win32_System_Threading"] }
 
 [build-dependencies]
 cc = "1"

build.Dockerfile

@@ -1,7 +1,7 @@
 # This Dockerfile produces a base image for builds.
 # It includes all dependencies necessary to cross-compile for Windows/MacOS/Linux.
 
-FROM debian:trixie AS osxcross
+FROM debian:bookworm AS osxcross
 ADD --chmod=644 "https://apt.llvm.org/llvm-snapshot.gpg.key" /etc/apt/trusted.gpg.d/apt.llvm.org.asc
 WORKDIR /build/osxcross
 ADD "https://github.com/tpoechtrager/osxcross.git#47936a512273bb3b414b5a2e83043c92eabc7ae7" .
@@ -10,30 +10,30 @@ RUN apt-get update && \
     apt-get install -y ca-certificates
 COPY llvm.sources /etc/apt/sources.list.d/llvm.sources
 RUN apt-get update && \
-    apt-get install -y bash bzip2 clang-22 git lld-22 llvm-22 make patch xz-utils && \
-    ln -s $(which clang-22) /usr/bin/clang && \
-    ln -s $(which clang++-22) /usr/bin/clang++ && \
-    ln -s $(which ld64.lld-22) /usr/bin/ld64.lld && \
+    apt-get install -y bash bzip2 clang-20 git lld-20 llvm-20 make patch xz-utils && \
+    ln -s $(which clang-20) /usr/bin/clang && \
+    ln -s $(which clang++-20) /usr/bin/clang++ && \
+    ln -s $(which ld64.lld-20) /usr/bin/ld64.lld && \
     SDK_VERSION=14.5 UNATTENDED=1 ENABLE_COMPILER_RT_INSTALL=1 TARGET_DIR=/osxcross ./build.sh
 
-FROM rust:1.97-trixie
+FROM rust:1.89-bookworm
 ADD --chmod=644 "https://apt.llvm.org/llvm-snapshot.gpg.key" /etc/apt/trusted.gpg.d/apt.llvm.org.asc
 COPY llvm.sources /etc/apt/sources.list.d/llvm.sources
 RUN rustup target add x86_64-pc-windows-msvc && \
     rustup target add x86_64-apple-darwin && \
     rustup target add aarch64-apple-darwin && \
     apt-get update && \
-    apt-get install -y clang-22 lld-22 libc6-dev libasound2-dev libudev-dev genisoimage mingw-w64 && \
+    apt-get install -y clang-20 lld-20 libc6-dev libasound2-dev libudev-dev genisoimage mingw-w64 && \
     cargo install cargo-bundle xwin && \
     xwin --accept-license splat --output xwin && \
     rm -rf .xwin-cache && \
-    ln -s $(which clang-22) /usr/bin/clang && \
-    ln -s $(which clang++-22) /usr/bin/clang++
+    ln -s $(which clang-20) /usr/bin/clang && \
+    ln -s $(which clang++-20) /usr/bin/clang++
 COPY --from=osxcross /osxcross /osxcross
 
 ENV PATH="/osxcross/bin:$PATH" \
     LD_LIBRARY_PATH="/osxcross/lib" \
-    CC="clang-22" CXX="clang++-22" AR="llvm-ar-22" \
+    CC="clang-20" CXX="clang++-20" AR="llvm-ar-20" \
     CC_x86_64-apple-darwin="o64-clang" \
     CXX_x86_64-apple-darwin="o64-clang++" \
     CC_aarch64-apple-darwin="oa64-clang" \
@@ -41,13 +41,12 @@ ENV PATH="/osxcross/bin:$PATH" \
     SHROOMS_CFLAGS_x86_64-unknown-linux-gnu="-flto" \
     CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUSTFLAGS="-Clinker-plugin-lto -Clinker=clang -Clink-arg=-fuse-ld=lld" \
     SHROOMS_CFLAGS_x86_64-pc-windows-msvc="-flto" \
-    CFLAGS_x86_64-pc-windows-msvc="-I/xwin/crt/include -I/xwin/sdk/include/ucrt -I/xwin/sdk/include/um -I/xwin/sdk/include/shared" \
     CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_RUSTFLAGS="-Lnative=/xwin/crt/lib/x86_64 -Lnative=/xwin/sdk/lib/um/x86_64 -Lnative=/xwin/sdk/lib/ucrt/x86_64 -Clinker-plugin-lto -Clink-arg=-fuse-ld=lld" \
-    CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_LINKER="lld-link-22" \
+    CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_LINKER="lld-link-20" \
     CARGO_TARGET_X86_64_APPLE_DARWIN_LINKER="o64-clang" \
-    CARGO_TARGET_X86_64_APPLE_DARWIN_AR="llvm-ar-22" \
+    CARGO_TARGET_X86_64_APPLE_DARWIN_AR="llvm-ar-20" \
     CARGO_TARGET_AARCH64_APPLE_DARWIN_LINKER="oa64-clang" \
-    CARGO_TARGET_AARCH64_APPLE_DARWIN_AR="llvm-ar-22" \
-    RC_PATH="llvm-rc-22" \
+    CARGO_TARGET_AARCH64_APPLE_DARWIN_AR="llvm-ar-20" \
+    RC_PATH="llvm-rc-20" \
     MACOSX_DEPLOYMENT_TARGET="14.5"
 ENTRYPOINT ["bash"]

build.rs

@@ -18,10 +18,8 @@ fn main() -> Result<(), Box<dyn Error>> {
     };
     builder
         .include(Path::new("shrooms-vb-core/core"))
-        .include(Path::new("shrooms-vb-core/util"))
         .opt_level(opt_level)
         .flag_if_supported("-fno-strict-aliasing")
-        .define("_CRT_SECURE_NO_WARNINGS", None)
         .define("VB_LITTLE_ENDIAN", None)
         .define("VB_SIGNED_PROPAGATE", None)
         .define("VB_DIV_GENERIC", None)
@@ -31,10 +29,7 @@ fn main() -> Result<(), Box<dyn Error>> {
         .define("VB_DIRECT_FRAME", "on_frame")
         .define("VB_DIRECT_READ", "on_read")
         .define("VB_DIRECT_WRITE", "on_write")
-        .define("VBU_REALLOC", "vbu_realloc_shim")
         .file(Path::new("shrooms-vb-core/core/vb.c"))
-        .file(Path::new("shrooms-vb-core/util/isx.c"))
-        .file(Path::new("shrooms-vb-core/util/vbu.c"))
         .compile("vb");
 
     Ok(())

llvm.sources

@@ -1,4 +1,4 @@
 Types: deb deb-src
-URIs: http://apt.llvm.org/trixie/
-Suites: llvm-toolchain-trixie-22
+URIs: http://apt.llvm.org/bookworm/
+Suites: llvm-toolchain-bookworm-20
 Components: main

shrooms-vb-core

@@ -1 +1 @@
-Subproject commit 31b740325288d9a92debc024a26bf1d689b3ac58
+Subproject commit 8598eab087cced12b92a411f6c7f2eb9de51310f

src/audio.rs

@@ -1,17 +1,17 @@
 use std::time::Duration;
 
 use anyhow::{Result, bail};
-use audioadapter_buffers::direct::InterleavedSlice;
 use cpal::traits::{DeviceTrait, HostTrait, StreamTrait};
-use rubato::{Adjustable as _, Resampler};
-use tracing::warn;
+use itertools::Itertools;
+use rubato::{FastFixedOut, Resampler};
+use tracing::error;
 
 pub struct Audio {
     #[allow(unused)]
     stream: cpal::Stream,
-    sampler: rubato::Async<f32>,
-    input_buffer: Vec<f32>,
-    output_buffer: Vec<f32>,
+    sampler: FastFixedOut<f32>,
+    input_buffer: Vec<Vec<f32>>,
+    output_buffer: Vec<Vec<f32>>,
     sample_sink: rtrb::Producer<f32>,
 }
 
@@ -23,32 +23,31 @@ impl Audio {
         let Some(device) = host.default_output_device() else {
             bail!("No output device available");
         };
-        let default_rate = device.default_output_config()?.sample_rate();
-        let Some(config) = device.supported_output_configs()?.find(|c| {
-            c.channels() == 2 && c.sample_format().is_float() && c.contains_rate(default_rate)
-        }) else {
+        let Some(config) = device
+            .supported_output_configs()?
+            .find(|c| c.channels() == 2 && c.sample_format().is_float())
+        else {
             bail!("No suitable output config available");
         };
-        let mut config = config.with_sample_rate(default_rate).config();
-        let resample_ratio = config.sample_rate as f64 / VB_FREQUENCY as f64;
+        let mut config = config.with_max_sample_rate().config();
+        let resample_ratio = config.sample_rate.0 as f64 / VB_FREQUENCY as f64;
         let chunk_size = (834.0 * resample_ratio) as usize;
-        let sampler = rubato::Async::new_poly(
+        let sampler = FastFixedOut::new(
             resample_ratio,
             64.0,
             rubato::PolynomialDegree::Cubic,
             chunk_size,
             2,
-            rubato::FixedAsync::Output,
         )?;
         config.buffer_size = cpal::BufferSize::Fixed(sampler.output_frames_max() as u32);
 
-        let input_buffer = Vec::with_capacity(sampler.nbr_channels() * sampler.input_frames_max());
-        let output_buffer = vec![0.0; sampler.nbr_channels() * sampler.output_frames_max()];
+        let input_buffer = sampler.input_buffer_allocate(true);
+        let output_buffer = sampler.output_buffer_allocate(true);
         let (sample_sink, mut sample_source) =
             rtrb::RingBuffer::new(sampler.output_frames_max() * 4);
 
         let stream = device.build_output_stream(
-            config,
+            &config,
             move |data: &mut [f32], _| {
                 let requested = data.len();
                 let chunk = match sample_source.read_chunk(data.len()) {
@@ -66,7 +65,7 @@ impl Audio {
                 }
                 chunk.commit_all();
             },
-            move |error| warn!(%error, "stream error"),
+            move |error| error!(%error, "stream error"),
             None,
         )?;
         stream.play()?;
@@ -79,38 +78,34 @@ impl Audio {
         })
     }
 
-    pub fn update(&mut self, mut samples: &[f32]) {
-        while self.input_buffer.len() + samples.len() >= self.sampler.input_frames_next() * 2 {
-            let samples_needed =
-                (self.sampler.input_frames_next() * 2).saturating_sub(self.input_buffer.len());
-            let (current_samples, future_samples) = samples.split_at(samples_needed);
-            self.input_buffer.extend_from_slice(current_samples);
-            samples = future_samples;
-
-            let buffer_in =
-                InterleavedSlice::new(&self.input_buffer, 2, self.sampler.input_frames_next())
-                    .unwrap();
-            let mut buffer_out = InterleavedSlice::new_mut(
-                &mut self.output_buffer,
-                2,
-                self.sampler.output_frames_next(),
-            )
-            .unwrap();
+    pub fn update(&mut self, samples: &[f32]) {
+        for sample in samples.chunks_exact(2) {
+            for (channel, value) in self.input_buffer.iter_mut().zip(sample) {
+                channel.push(*value);
+            }
+            if self.input_buffer[0].len() >= self.sampler.input_frames_next() {
                 let (_, output_samples) = self
                     .sampler
-                .process_into_buffer(&buffer_in, &mut buffer_out, None)
+                    .process_into_buffer(&self.input_buffer, &mut self.output_buffer, None)
                     .unwrap();
+
                 let chunk = match self.sample_sink.write_chunk_uninit(output_samples * 2) {
                     Ok(c) => c,
                     Err(rtrb::chunks::ChunkError::TooFewSlots(n)) => {
                         self.sample_sink.write_chunk_uninit(n).unwrap()
                     }
                 };
-            chunk.fill_from_iter(self.output_buffer[..output_samples * 2].iter().copied());
+                let interleaved = self.output_buffer[0]
+                    .iter()
+                    .interleave(self.output_buffer[1].iter())
+                    .cloned();
+                chunk.fill_from_iter(interleaved);
 
-            self.input_buffer.clear();
+                for channel in &mut self.input_buffer {
+                    channel.clear();
+                }
+            }
         }
-        self.input_buffer.extend_from_slice(samples);
 
         while self.sample_sink.slots() < self.sampler.output_frames_max() * 2 {
             std::thread::sleep(Duration::from_micros(500));

src/config.rs

@@ -1,171 +0,0 @@
-use anyhow::Result;
-use clap::{Parser, ValueEnum};
-use egui::{Color32, Pos2, Vec2};
-use serde::{Deserialize, Serialize};
-
-use crate::{emulator::SimId, persistence::Persistence, window::DisplayMode};
-use std::path::PathBuf;
-
-#[derive(Parser)]
-#[command(version, long_version = env!("CARGO_PKG_VERSION"))]
-pub struct CliArgs {
-    /// The path to a virtual boy ROM to run.
-    pub rom: Option<PathBuf>,
-    /// Start a GDB/LLDB debug server on this port.
-    #[arg(short, long)]
-    pub debug_port: Option<u16>,
-    /// Enable profiling a game
-    #[arg(short, long)]
-    pub profile: bool,
-    /// Open character data window
-    #[arg(short, long)]
-    pub character_data: bool,
-    /// Open bgmap data window
-    #[arg(short, long)]
-    pub bgmap_data: bool,
-    /// Open object data window
-    #[arg(short, long)]
-    pub object_data: bool,
-    /// Open worlds window
-    #[arg(long)]
-    pub worlds: bool,
-    /// Open frame buffers window
-    #[arg(short, long)]
-    pub frame_buffers: bool,
-    /// Open registers window
-    #[arg(short, long)]
-    pub registers: bool,
-    /// Open terminal
-    #[arg(short, long)]
-    pub terminal: bool,
-    /// Watch ROM files for changes, automatically reload
-    #[arg(short, long)]
-    pub watch: bool,
-    /// Automatically open Player 2 for multiplayer
-    #[arg(long)]
-    pub player2: bool,
-    /// Map the first connected controller to Player 2
-    #[arg(long)]
-    pub player2_controller: bool,
-    /// Force the application to render with CPU, rather than GPU.
-    #[arg(long)]
-    pub wgpu_force_fallback: Option<bool>,
-    /// Set a preference for whether to use a low-power or high-performance GPU adapter
-    #[arg(long)]
-    pub wgpu_power_preference: Option<PowerPreferenceWrapper>,
-}
-
-#[derive(ValueEnum, Clone, Copy)]
-pub enum PowerPreferenceWrapper {
-    Low,
-    High,
-    None,
-}
-impl From<PowerPreferenceWrapper> for wgpu::PowerPreference {
-    fn from(value: PowerPreferenceWrapper) -> Self {
-        match value {
-            PowerPreferenceWrapper::Low => wgpu::PowerPreference::LowPower,
-            PowerPreferenceWrapper::High => wgpu::PowerPreference::HighPerformance,
-            PowerPreferenceWrapper::None => wgpu::PowerPreference::None,
-        }
-    }
-}
-
-pub const COLOR_PRESETS: [[Color32; 2]; 3] = [
-    [
-        Color32::from_rgb(0xff, 0x00, 0x00),
-        Color32::from_rgb(0x00, 0xc6, 0xf0),
-    ],
-    [
-        Color32::from_rgb(0x00, 0xb4, 0x00),
-        Color32::from_rgb(0xc8, 0x00, 0xff),
-    ],
-    [
-        Color32::from_rgb(0xb4, 0x9b, 0x00),
-        Color32::from_rgb(0x00, 0x00, 0xff),
-    ],
-];
-
-const fn default_power_preference() -> wgpu::PowerPreference {
-    wgpu::PowerPreference::LowPower
-}
-
-#[derive(Serialize, Deserialize, Clone, PartialEq, Eq)]
-pub struct AppConfig {
-    #[serde(default = "default_power_preference")]
-    pub power_preference: wgpu::PowerPreference,
-    #[serde(default)]
-    pub force_fallback: bool,
-}
-
-impl AppConfig {
-    pub fn load(persistence: &Persistence) -> Self {
-        if let Ok(config) = persistence.load_config(APP_CONFIG_FILENAME) {
-            return config;
-        }
-        Self {
-            power_preference: default_power_preference(),
-            force_fallback: false,
-        }
-    }
-
-    pub fn save(&self, persistence: &Persistence) -> Result<()> {
-        persistence.save_config(APP_CONFIG_FILENAME, &self)
-    }
-
-    pub fn update(&mut self, args: &CliArgs) -> bool {
-        let mut updated = false;
-        if let Some(pref) = args.wgpu_power_preference {
-            self.power_preference = pref.into();
-            updated = true;
-        }
-        if let Some(force_fallback) = args.wgpu_force_fallback {
-            self.force_fallback = force_fallback;
-            updated = true;
-        }
-        updated
-    }
-}
-
-const APP_CONFIG_FILENAME: &str = "config";
-
-const fn default_audio_enabled() -> bool {
-    true
-}
-
-#[derive(Serialize, Deserialize, Clone, PartialEq, Eq)]
-pub struct SimConfig {
-    pub display_mode: DisplayMode,
-    pub colors: [Color32; 2],
-    pub dimensions: Vec2,
-    #[serde(default = "default_audio_enabled")]
-    pub audio_enabled: bool,
-    #[serde(default)]
-    pub position: Option<Pos2>,
-}
-
-impl SimConfig {
-    pub fn load(persistence: &Persistence, sim_id: SimId) -> Self {
-        if let Ok(config) = persistence.load_config(sim_config_filename(sim_id)) {
-            return config;
-        }
-        Self {
-            display_mode: DisplayMode::Anaglyph,
-            colors: COLOR_PRESETS[0],
-            dimensions: DisplayMode::Anaglyph.proportions() + Vec2::new(0.0, 22.0),
-            audio_enabled: true,
-            position: None,
-        }
-    }
-
-    pub fn save(&self, persistence: &Persistence, sim_id: SimId) -> Result<()> {
-        persistence.save_config(sim_config_filename(sim_id), self)
-    }
-}
-
-fn sim_config_filename(sim_id: SimId) -> &'static str {
-    match sim_id {
-        SimId::Player1 => "config_p1",
-        SimId::Player2 => "config_p2",
-    }
-}

src/controller.rs

@@ -1,7 +1,4 @@
-use std::{
-    collections::HashMap,
-    sync::{Arc, RwLock},
-};
+use std::sync::{Arc, RwLock};
 
 use gilrs::{Event as GamepadEvent, EventType, GamepadId, ev::Code};
 use winit::{
@@ -11,13 +8,12 @@ use winit::{
 
 use crate::{
     emulator::{EmulatorClient, EmulatorCommand, SimId, VBKey},
-    input::{AxisMapping, InputMapping, MappingProvider},
+    input::{InputMapping, MappingProvider},
 };
 
 pub struct Controller {
     pub sim_id: SimId,
     state: VBKey,
-    axis_values: HashMap<(GamepadId, Code), f32>,
     mapping: Arc<RwLock<InputMapping>>,
 }
 
@@ -26,7 +22,6 @@ impl Controller {
         Self {
             sim_id,
             state: VBKey::SGN,
-            axis_values: HashMap::new(),
             mapping: mappings.for_sim(sim_id).clone(),
         }
     }
@@ -50,23 +45,20 @@ impl Controller {
                 (VBKey::empty(), mappings)
             }
             EventType::AxisChanged(_, value, code) => {
-                let mapping = self.map_axis(&event.id, &code)?;
-                self.axis_values.insert((event.id, code), value);
-
-                let pair_value = mapping
-                    .pair
-                    .and_then(|p| self.axis_values.get(&(event.id, p)))
-                    .copied()
-                    .unwrap_or_default();
-                let neg = mapping.neg;
-                let pos = mapping.pos;
-
-                let (mut pressed, mut released) = axis_presses(value, pair_value, neg, pos);
-                if let Some(other) = mapping.pair.and_then(|p| self.map_axis(&event.id, &p)) {
-                    let (other_pressed, other_released) =
-                        axis_presses(pair_value, value, other.neg, other.pos);
-                    pressed = pressed.union(other_pressed);
-                    released = released.union(other_released);
+                let (neg, pos) = self.map_axis(&event.id, &code)?;
+                let mut pressed = VBKey::empty();
+                let mut released = VBKey::empty();
+                if value < -0.75 {
+                    pressed = pressed.union(neg);
+                }
+                if value > 0.75 {
+                    pressed = pressed.union(pos);
+                }
+                if value > -0.65 {
+                    released = released.union(neg);
+                }
+                if value < 0.65 {
+                    released = released.union(pos);
                 }
                 (pressed, released)
             }
@@ -95,7 +87,7 @@ impl Controller {
         self.mapping.read().unwrap().map_button(id, code)
     }
 
-    fn map_axis(&self, id: &GamepadId, code: &Code) -> Option<AxisMapping> {
+    fn map_axis(&self, id: &GamepadId, code: &Code) -> Option<(VBKey, VBKey)> {
         self.mapping.read().unwrap().map_axis(id, code)
     }
 }
@@ -134,95 +126,3 @@ impl ControllerManager {
         }
     }
 }
-
-fn axis_presses(value: f32, pair_value: f32, neg: VBKey, pos: VBKey) -> (VBKey, VBKey) {
-    use std::f32::consts::FRAC_PI_3;
-
-    let mut pressed = VBKey::empty();
-    let mut released = VBKey::empty();
-
-    let magnitude = value.hypot(pair_value);
-    let abs_angle = pair_value.atan2(value).abs();
-
-    if magnitude < 0.65 {
-        released = released.union(neg).union(pos);
-    } else if abs_angle <= FRAC_PI_3 {
-        // stick tilted towards positive
-        released = released.union(neg);
-
-        if magnitude >= 0.75 {
-            pressed = pressed.union(pos);
-        }
-    } else if abs_angle >= 2.0 * FRAC_PI_3 {
-        // stick tilted towards negative
-        released = released.union(pos);
-
-        if magnitude >= 0.75 {
-            pressed = pressed.union(neg);
-        }
-    } else {
-        released = released.union(neg).union(pos);
-    }
-
-    (pressed, released)
-}
-
-#[cfg(test)]
-mod tests {
-    use super::{VBKey, axis_presses};
-
-    const NEG: VBKey = VBKey::LL;
-    const POS: VBKey = VBKey::LR;
-
-    const NONE: VBKey = VBKey::empty();
-    const BOTH: VBKey = NEG.union(POS);
-
-    #[test]
-    fn detects_no_input() {
-        let (pressed, released) = axis_presses(0.0, 0.0, NEG, POS);
-        assert_eq!(pressed, NONE);
-        assert_eq!(released, BOTH);
-    }
-
-    #[test]
-    fn detects_pos_input() {
-        let (pressed, released) = axis_presses(1.0, 0.0, NEG, POS);
-        assert_eq!(pressed, POS);
-        assert_eq!(released, NEG);
-    }
-
-    #[test]
-    fn detects_neg_input() {
-        let (pressed, released) = axis_presses(-1.0, 0.0, NEG, POS);
-        assert_eq!(pressed, NEG);
-        assert_eq!(released, POS);
-    }
-
-    #[test]
-    fn respects_dead_zone() {
-        let (pressed, released) = axis_presses(0.70, 0.0, NEG, POS);
-        assert_eq!(pressed, NONE);
-        assert_eq!(released, NEG);
-    }
-
-    #[test]
-    fn handles_diagonals_ok() {
-        let (pressed, released) = axis_presses(0.6, 0.6, NEG, POS);
-        assert_eq!(pressed, POS);
-        assert_eq!(released, NEG);
-    }
-
-    #[test]
-    fn ignores_diagonal_noise() {
-        let (pressed, released) = axis_presses(-1.0, -0.1484245, NEG, POS);
-        assert_eq!(pressed, NEG);
-        assert_eq!(released, POS);
-    }
-
-    #[test]
-    fn ignores_small_values() {
-        let (pressed, released) = axis_presses(-0.1484245, -1.0, NEG, POS);
-        assert_eq!(pressed, NONE);
-        assert_eq!(released, BOTH);
-    }
-}

src/emulator.rs

@@ -5,7 +5,7 @@ use std::{
     sync::{
         Arc, Weak,
         atomic::{AtomicBool, Ordering},
-        mpsc::{self, RecvTimeoutError, TryRecvError},
+        mpsc::{self, RecvError, TryRecvError},
     },
     time::Duration,
 };
@@ -33,7 +33,6 @@ mod cart;
 mod game_info;
 mod inline_stack_map;
 mod shrooms_vb_core;
-mod shrooms_vb_util;
 
 #[derive(PartialEq, Eq, Hash, Clone, Copy, Debug)]
 pub enum SimId {
@@ -75,7 +74,6 @@ pub struct EmulatorBuilder {
     audio_on: Arc<[AtomicBool; 2]>,
     linked: Arc<AtomicBool>,
     start_paused: bool,
-    watch_rom: Arc<[AtomicBool; 2]>,
 }
 
 impl EmulatorBuilder {
@@ -92,13 +90,12 @@ impl EmulatorBuilder {
             audio_on: Arc::new([AtomicBool::new(true), AtomicBool::new(true)]),
             linked: Arc::new(AtomicBool::new(false)),
             start_paused: false,
-            watch_rom: Arc::new([AtomicBool::new(false), AtomicBool::new(false)]),
         };
         let client = EmulatorClient {
             queue,
             sim_state: builder.sim_state.clone(),
             state: builder.state.clone(),
-            watch_rom: builder.watch_rom.clone(),
+            audio_on: builder.audio_on.clone(),
             linked: builder.linked.clone(),
         };
         (builder, client)
@@ -118,25 +115,12 @@ impl EmulatorBuilder {
         }
     }
 
-    pub fn with_audio_on(self, p1: bool, p2: bool) -> Self {
-        self.audio_on[0].store(p1, Ordering::Relaxed);
-        self.audio_on[1].store(p2, Ordering::Relaxed);
-        self
-    }
-
-    pub fn with_watch_rom(self, p1: bool, p2: bool) -> Self {
-        self.watch_rom[0].store(p1, Ordering::Relaxed);
-        self.watch_rom[1].store(p2, Ordering::Relaxed);
-        self
-    }
-
     pub fn build(self) -> Result<Emulator> {
         let mut emulator = Emulator::new(
             self.commands,
             self.sim_state,
             self.state,
             self.audio_on,
-            self.watch_rom,
             self.linked,
         )?;
         if let Some(path) = self.rom {
@@ -157,7 +141,6 @@ pub struct Emulator {
     sim_state: Arc<[Atomic<SimState>; 2]>,
     state: Arc<Atomic<EmulatorState>>,
     audio_on: Arc<[AtomicBool; 2]>,
-    watch_rom: Arc<[AtomicBool; 2]>,
     linked: Arc<AtomicBool>,
     profilers: [Option<ProfileSender>; 2],
     renderers: HashMap<SimId, TextureSink>,
@@ -176,7 +159,6 @@ impl Emulator {
         sim_state: Arc<[Atomic<SimState>; 2]>,
         state: Arc<Atomic<EmulatorState>>,
         audio_on: Arc<[AtomicBool; 2]>,
-        watch_rom: Arc<[AtomicBool; 2]>,
         linked: Arc<AtomicBool>,
     ) -> Result<Self> {
         Ok(Self {
@@ -187,7 +169,6 @@ impl Emulator {
             sim_state,
             state,
             audio_on,
-            watch_rom,
             linked,
             profilers: [None, None],
             renderers: HashMap::new(),
@@ -201,18 +182,9 @@ impl Emulator {
         })
     }
 
-    pub fn reload_cart(&mut self, sim_id: SimId) -> Result<()> {
-        let Some(cart) = &self.carts[sim_id.to_index()] else {
-            return Ok(());
-        };
-        let path = cart.file_path.clone();
-        self.load_cart(sim_id, &path)
-    }
-
     pub fn load_cart(&mut self, sim_id: SimId, path: &Path) -> Result<()> {
-        let watch = self.watch_rom[sim_id.to_index()].load(Ordering::Acquire);
-        let cart = Cart::load(path, sim_id, watch)?;
-        self.try_reset_sim(sim_id, Some(cart))?;
+        let cart = Cart::load(path, sim_id)?;
+        self.reset_sim(sim_id, Some(cart))?;
         Ok(())
     }
 
@@ -222,26 +194,16 @@ impl Emulator {
         } else {
             self.carts[0].as_ref().map(|c| c.file_path.clone())
         };
-        let watch = self.watch_rom[SimId::Player2.to_index()].load(Ordering::Acquire);
         let cart = match file_path {
-            Some(rom_path) => Some(Cart::load(&rom_path, SimId::Player2, watch)?),
+            Some(rom_path) => Some(Cart::load(&rom_path, SimId::Player2)?),
             None => None,
         };
-        self.try_reset_sim(SimId::Player2, cart)?;
+        self.reset_sim(SimId::Player2, cart)?;
         self.link_sims();
         Ok(())
     }
 
-    fn reset_sim(&mut self, sim_id: SimId, new_cart: Option<Cart>) -> bool {
-        if let Err(error) = self.try_reset_sim(sim_id, new_cart) {
-            self.report_error(sim_id, format!("Error resetting sim: {error}"));
-            false
-        } else {
-            true
-        }
-    }
-
-    fn try_reset_sim(&mut self, sim_id: SimId, new_cart: Option<Cart>) -> Result<()> {
+    fn reset_sim(&mut self, sim_id: SimId, new_cart: Option<Cart>) -> Result<()> {
         self.save_sram(sim_id)?;
 
         let index = sim_id.to_index();
@@ -262,11 +224,6 @@ impl Emulator {
             sim.load_cart(cart.rom.clone(), cart.sram.clone())?;
             self.carts[index] = Some(cart);
             self.sim_state[index].store(SimState::Ready, Ordering::Release);
-        } else if let Some(cart) = self.carts[index].as_mut()
-            && cart.is_watching()
-        {
-            cart.reload()?;
-            sim.load_cart(cart.rom.clone(), cart.sram.clone())?;
         }
         let mut profiling = false;
         if let Some(profiler) = self.profilers[sim_id.to_index()].as_ref()
@@ -383,7 +340,7 @@ impl Emulator {
 
     fn start_profiling(&mut self, sim_id: SimId, sender: ProfileSender) -> Result<()> {
         self.profilers[sim_id.to_index()] = Some(sender);
-        self.try_reset_sim(sim_id, None)
+        self.reset_sim(sim_id, None)
     }
 
     fn start_debugging(&mut self, sim_id: SimId, sender: DebugSender) {
@@ -459,33 +416,14 @@ impl Emulator {
             let idle = self.tick();
             if idle {
                 // The game is paused, and we have output all the video/audio we have.
-                // Block the thread until a new command comes in, or a ROM changes.
-                loop {
-                    match self.commands.recv_timeout(Duration::from_millis(250)) {
-                        Ok(command) => {
-                            self.handle_command(command);
-                            break;
-                        }
-                        Err(RecvTimeoutError::Timeout) => {
-                            let mut changed = false;
-                            for sim_id in SimId::values() {
-                                let Some(cart) = self.carts[sim_id.to_index()].as_ref() else {
-                                    continue;
-                                };
-                                if cart.changed() {
-                                    changed |= self.reset_sim(sim_id, None);
-                                }
-                            }
-                            if changed {
-                                break;
-                            }
-                        }
-                        Err(RecvTimeoutError::Disconnected) => {
+                // Block the thread until a new command comes in.
+                match self.commands.recv() {
+                    Ok(command) => self.handle_command(command),
+                    Err(RecvError) => {
                         return;
                     }
                 }
             }
-            }
             loop {
                 match self.commands.try_recv() {
                     Ok(command) => self.handle_command(command),
@@ -497,14 +435,6 @@ impl Emulator {
                     }
                 }
             }
-            for sim_id in SimId::values() {
-                let Some(cart) = self.carts[sim_id.to_index()].as_ref() else {
-                    continue;
-                };
-                if cart.changed() {
-                    self.reset_sim(sim_id, None);
-                }
-            }
             self.watched_regions.retain(|range, region| {
                 let Some(region) = region.upgrade() else {
                     return false;
@@ -671,22 +601,6 @@ impl Emulator {
                     self.report_error(sim_id, format!("Error loading rom: {error}"));
                 }
             }
-            EmulatorCommand::ReloadRom(sim_id) => {
-                if let Err(error) = self.reload_cart(sim_id) {
-                    self.report_error(sim_id, format!("Error loading rom: {error}"));
-                }
-            }
-            EmulatorCommand::WatchRom(sim_id, watch) => {
-                self.watch_rom[sim_id.to_index()].store(watch, Ordering::Release);
-                let Some(cart) = self.carts[sim_id.to_index()].as_mut() else {
-                    return;
-                };
-                if watch {
-                    cart.restart_watching();
-                } else {
-                    cart.stop_watching();
-                }
-            }
             EmulatorCommand::StartSecondSim(path) => {
                 if let Err(error) = self.start_second_sim(path) {
                     self.report_error(
@@ -800,8 +714,9 @@ impl Emulator {
                 };
                 sim.watch_stdout(true);
             }
-            EmulatorCommand::SetAudioEnabled(sim_id, enabled) => {
-                self.audio_on[sim_id.to_index()].store(enabled, Ordering::Release);
+            EmulatorCommand::SetAudioEnabled(p1, p2) => {
+                self.audio_on[SimId::Player1.to_index()].store(p1, Ordering::Release);
+                self.audio_on[SimId::Player2.to_index()].store(p2, Ordering::Release);
             }
             EmulatorCommand::Link => {
                 self.link_sims();
@@ -810,7 +725,9 @@ impl Emulator {
                 self.unlink_sims();
             }
             EmulatorCommand::Reset(sim_id) => {
-                self.reset_sim(sim_id, None);
+                if let Err(error) = self.reset_sim(sim_id, None) {
+                    self.report_error(sim_id, format!("Error resetting sim: {error}"));
+                }
             }
             EmulatorCommand::SetKeys(sim_id, keys) => {
                 if let Some(sim) = self.sims.get_mut(sim_id.to_index()) {
@@ -852,8 +769,6 @@ impl Emulator {
 pub enum EmulatorCommand {
     ConnectToSim(SimId, TextureSink, mpsc::Sender<Toast>),
     LoadGame(SimId, PathBuf),
-    ReloadRom(SimId),
-    WatchRom(SimId, bool),
     StartSecondSim(Option<PathBuf>),
     StopSecondSim,
     Pause,
@@ -876,7 +791,7 @@ pub enum EmulatorCommand {
     AddWatchpoint(SimId, u32, usize, VBWatchpointType),
     RemoveWatchpoint(SimId, u32, usize, VBWatchpointType),
     WatchStdout(SimId, mpsc::Sender<String>),
-    SetAudioEnabled(SimId, bool),
+    SetAudioEnabled(bool, bool),
     Link,
     Unlink,
     Reset(SimId),
@@ -942,26 +857,23 @@ pub struct EmulatorClient {
     queue: mpsc::Sender<EmulatorCommand>,
     sim_state: Arc<[Atomic<SimState>; 2]>,
     state: Arc<Atomic<EmulatorState>>,
+    audio_on: Arc<[AtomicBool; 2]>,
     linked: Arc<AtomicBool>,
-    watch_rom: Arc<[AtomicBool; 2]>,
 }
 
 impl EmulatorClient {
-    pub fn has_player_2(&self) -> bool {
-        self.sim_state(SimId::Player2) != SimState::Uninitialized
-    }
     pub fn sim_state(&self, sim_id: SimId) -> SimState {
         self.sim_state[sim_id.to_index()].load(Ordering::Acquire)
     }
     pub fn emulator_state(&self) -> EmulatorState {
         self.state.load(Ordering::Acquire)
     }
+    pub fn is_audio_enabled(&self, sim_id: SimId) -> bool {
+        self.audio_on[sim_id.to_index()].load(Ordering::Acquire)
+    }
     pub fn are_sims_linked(&self) -> bool {
         self.linked.load(Ordering::Acquire)
     }
-    pub fn is_rom_watched(&self, sim_id: SimId) -> bool {
-        self.watch_rom[sim_id.to_index()].load(Ordering::Acquire)
-    }
     pub fn send_command(&self, command: EmulatorCommand) -> bool {
         match self.queue.send(command) {
             Ok(()) => true,

src/emulator/cart.rs

@@ -1,14 +1,13 @@
 use anyhow::Result;
-use notify::Watcher;
-use rand::RngExt;
+use rand::Rng;
 use std::{
     fs::{self, File},
     io::{Read, Seek as _, SeekFrom, Write as _},
     path::{Path, PathBuf},
-    sync::{Arc, atomic::AtomicBool},
+    sync::Arc,
 };
 
-use crate::emulator::{SimId, game_info::GameInfo, shrooms_vb_util::rom_from_isx};
+use crate::emulator::{SimId, game_info::GameInfo};
 
 pub struct Cart {
     pub file_path: PathBuf,
@@ -16,13 +15,13 @@ pub struct Cart {
     sram_file: File,
     pub sram: Vec<u8>,
     pub info: Arc<GameInfo>,
-    watcher: Option<notify::RecommendedWatcher>,
-    changed: Arc<AtomicBool>,
 }
 
 impl Cart {
-    pub fn load(file_path: &Path, sim_id: SimId, watch: bool) -> Result<Self> {
-        let (rom, info) = Self::read_rom(file_path)?;
+    pub fn load(file_path: &Path, sim_id: SimId) -> Result<Self> {
+        let rom = fs::read(file_path)?;
+        let (rom, info) =
+            try_parse_elf(file_path, &rom).unwrap_or_else(|| (rom, GameInfo::empty(file_path)));
 
         let mut sram_file = File::options()
             .read(true)
@@ -45,97 +44,20 @@ impl Cart {
             sram
         };
 
-        let changed = Arc::new(AtomicBool::new(false));
-        let watcher = if watch {
-            build_watcher(file_path, changed.clone())
-        } else {
-            None
-        };
-
         Ok(Cart {
             file_path: file_path.to_path_buf(),
             rom,
             sram_file,
             sram,
             info: Arc::new(info),
-            watcher,
-            changed,
         })
     }
 
-    pub fn reload(&mut self) -> Result<()> {
-        let (rom, info) = Self::read_rom(&self.file_path)?;
-        self.rom = rom;
-        self.info = Arc::new(info);
-        if self.is_watching() {
-            self.restart_watching();
-        }
-        Ok(())
-    }
-
     pub fn save_sram(&mut self) -> Result<()> {
         self.sram_file.seek(SeekFrom::Start(0))?;
         self.sram_file.write_all(&self.sram)?;
         Ok(())
     }
-
-    pub fn changed(&self) -> bool {
-        self.changed.load(std::sync::atomic::Ordering::Relaxed)
-    }
-
-    pub fn is_watching(&self) -> bool {
-        self.watcher.is_some()
-    }
-
-    pub fn restart_watching(&mut self) {
-        self.changed = Arc::new(AtomicBool::new(false));
-        if let Some(mut watcher) = self.watcher.take() {
-            let _ = watcher.unwatch(&self.file_path);
-        };
-        self.watcher = build_watcher(&self.file_path, self.changed.clone());
-    }
-
-    pub fn stop_watching(&mut self) {
-        self.changed = Arc::new(AtomicBool::new(false));
-        self.watcher = None;
-    }
-
-    fn read_rom(file_path: &Path) -> Result<(Vec<u8>, GameInfo)> {
-        let rom = fs::read(file_path)?;
-        let (rom, info) = try_parse_isx(file_path, &rom)
-            .or_else(|| try_parse_elf(file_path, &rom))
-            .unwrap_or_else(|| (rom, GameInfo::empty(file_path)));
-        Ok((rom, info))
-    }
-}
-
-fn build_watcher(file_path: &Path, changed: Arc<AtomicBool>) -> Option<notify::RecommendedWatcher> {
-    let file_path = file_path.to_path_buf();
-    let mut watcher =
-        notify::recommended_watcher(move |event: Result<notify::Event, notify::Error>| {
-            let Ok(e) = event else {
-                return;
-            };
-            let modified = !matches!(
-                e.kind,
-                notify::EventKind::Access(_)
-                    | notify::EventKind::Modify(notify::event::ModifyKind::Metadata(_))
-            );
-            if modified {
-                changed.store(true, std::sync::atomic::Ordering::Relaxed);
-            }
-        })
-        .ok()?;
-    watcher
-        .watch(&file_path, notify::RecursiveMode::NonRecursive)
-        .ok()?;
-    Some(watcher)
-}
-
-fn try_parse_isx(file_path: &Path, data: &[u8]) -> Option<(Vec<u8>, GameInfo)> {
-    let rom = rom_from_isx(data)?;
-    let info = GameInfo::from_isx(file_path, data);
-    Some((rom, info))
 }
 
 fn try_parse_elf(file_path: &Path, data: &[u8]) -> Option<(Vec<u8>, GameInfo)> {
@@ -151,7 +73,7 @@ fn try_parse_elf(file_path: &Path, data: &[u8]) -> Option<(Vec<u8>, GameInfo)> {
         }
         _ => return None,
     };
-    let info = GameInfo::from_elf(file_path, data).unwrap_or_else(|_| GameInfo::empty(file_path));
+    let info = GameInfo::new(file_path, data).unwrap_or_else(|_| GameInfo::empty(file_path));
     Some((program, info))
 }
 
@@ -164,13 +86,12 @@ fn parse_elf_program<Elf: object::read::elf::FileHeader<Endian = object::Endiann
     let mut bytes = vec![];
     let mut pstart = None;
     for phdr in header.program_headers(endian, data).ok()? {
-        let pma = phdr.p_paddr(endian).into();
-        if pma < 0x07000000 || phdr.p_filesz(endian).into() == 0 {
+        if phdr.p_filesz(endian).into() == 0 {
             continue;
         }
-        let start = pstart.unwrap_or(pma);
+        let start = pstart.unwrap_or(phdr.p_paddr(endian).into());
         pstart = Some(start);
-        bytes.resize((pma - start) as usize, 0);
+        bytes.resize((phdr.p_paddr(endian).into() - start) as usize, 0);
         let data = phdr.data(endian, data).ok()?;
         bytes.extend_from_slice(data);
     }

src/emulator/game_info.rs

@@ -14,7 +14,7 @@ pub struct GameInfo {
 }
 
 impl GameInfo {
-    pub fn from_elf(file_path: &Path, input: &[u8]) -> Result<Self> {
+    pub fn new(file_path: &Path, input: &[u8]) -> Result<Self> {
         let file = object::File::parse(input)?;
 
         let (name, path) = name_and_path(file_path);
@@ -52,26 +52,6 @@ impl GameInfo {
         })
     }
 
-    pub fn from_isx(file_path: &Path, input: &[u8]) -> Self {
-        let (name, path) = name_and_path(file_path);
-        let symbols = extract_isx_symbols(input);
-        let library_info = LibraryInfo {
-            name: name.clone(),
-            debug_name: name,
-            path: path.clone(),
-            debug_path: path,
-            debug_id: DebugId::default(),
-            code_id: None,
-            arch: None,
-            symbol_table: symbols.map(|syms| Arc::new(SymbolTable::new(syms))),
-        };
-        let inline_stack_map = InlineStackMap::empty();
-        Self {
-            library_info,
-            inline_stack_map,
-        }
-    }
-
     pub fn empty(file_path: &Path) -> Self {
         let (name, path) = name_and_path(file_path);
         let library_info = LibraryInfo {
@@ -135,66 +115,6 @@ fn build_inline_stack_map(file: object::File) -> Result<InlineStackMap> {
     Ok(frames.build())
 }
 
-fn extract_isx_symbols(input: &[u8]) -> Option<Vec<Symbol>> {
-    let mut syms = vec![];
-    let (_, mut buf) = input.split_at_checked(32)?;
-    while !buf.is_empty() {
-        let typ;
-        (typ, buf) = buf.split_first()?;
-        match typ {
-            0x11 => {
-                // Code (Virtual Boy)
-                (_, buf) = buf.split_at_checked(4)?;
-                let len_bytes;
-                (len_bytes, buf) = buf.split_first_chunk()?;
-                let len = u32::from_le_bytes(*len_bytes);
-                (_, buf) = buf.split_at_checked(len as usize)?;
-            }
-            0x13 => {
-                // Range (Virtual Boy)
-                let count_bytes;
-                (count_bytes, buf) = buf.split_first_chunk()?;
-                let count = u16::from_le_bytes(*count_bytes);
-                (_, buf) = buf.split_at_checked(count as usize * 9)?;
-            }
-            0x14 => {
-                // Symbol (Virtual Boy)
-                let count_bytes;
-                (count_bytes, buf) = buf.split_first_chunk()?;
-                let count = u16::from_le_bytes(*count_bytes);
-                for _ in 0..count {
-                    let name_len;
-                    (name_len, buf) = buf.split_first()?;
-                    let name_bytes;
-                    (name_bytes, buf) = buf.split_at_checked(*name_len as usize)?;
-                    (_, buf) = buf.split_at_checked(2)?;
-                    let address_bytes;
-                    (address_bytes, buf) = buf.split_first_chunk()?;
-
-                    let name_str = String::from_utf8_lossy(name_bytes);
-                    let address = u32::from_le_bytes(*address_bytes);
-                    syms.push(Symbol {
-                        address: address & 0x07ffffff,
-                        size: Some(4),
-                        name: demangle_any(&name_str),
-                    });
-                }
-            }
-            0x20..=0x22 => {
-                // System (undocumented)
-                let length_bytes;
-                (length_bytes, buf) = buf.split_first_chunk()?;
-                let length = u32::from_le_bytes(*length_bytes);
-                (_, buf) = buf.split_at_checked(length as usize)?;
-            }
-            _ => {
-                return None;
-            }
-        }
-    }
-    Some(syms)
-}
-
 type Reader<'a> = gimli::EndianSlice<'a, gimli::RunTimeEndian>;
 
 struct ParseContext<'a> {
@@ -245,19 +165,16 @@ impl ParseContext<'_> {
     }
 }
 
-fn parse_inline<'a>(
-    ctx: &mut ParseContext<'a>,
-    node: gimli::EntriesTreeNode<'a, '_, Reader<'a>>,
-) -> Result<()> {
+fn parse_inline(ctx: &mut ParseContext, node: gimli::EntriesTreeNode<Reader>) -> Result<()> {
     if node.entry().tag() == gimli::DW_TAG_inlined_subroutine
-        && let Some(attr) = node.entry().attr_value(gimli::DW_AT_abstract_origin)
+        && let Some(attr) = node.entry().attr_value(gimli::DW_AT_abstract_origin)?
         && let Some(name) = ctx.name_attr(attr)?
     {
         let name = Arc::new(name);
         let mut ranges = ctx.dorf.die_ranges(ctx.unit, node.entry())?;
         while let Some(range) = ranges.next()? {
-            let start = range.begin as u32 & 0x07ffffff;
-            let end = range.end as u32 & 0x07ffffff;
+            let start = range.begin as u32;
+            let end = range.end as u32;
             ctx.frames.add(start, end, name.clone());
         }
     }

src/emulator/shrooms_vb_core.rs

@@ -261,7 +261,7 @@ extern "C" fn on_exception(sim: *mut VB, cause: *mut u16) -> c_int {
     };
     data.monitor.event = data.monitor.queued_event.take();
     data.monitor.new_inline_stack = data.monitor.detect_new_inline_stack(pc);
-    data.monitor.queued_event = Some(SimEvent::Interrupt(cause, pc & 0x07ffffff));
+    data.monitor.queued_event = Some(SimEvent::Interrupt(cause, pc));
     unsafe { vb_set_exception_callback(sim, None) };
     if data.monitor.event.is_some() || data.monitor.new_inline_stack.is_some() {
         1
@@ -439,9 +439,7 @@ impl EventMonitor {
                 // JAL .+4 is how programs get r31 to a known value for indirect calls
                 // (which we detect later.)
                 // Any other JAL is a function call.
-                return Some(SimEvent::Call(
-                    address.wrapping_add_signed(disp) & 0x07ffffff,
-                ));
+                return Some(SimEvent::Call(address.wrapping_add_signed(disp)));
             }
         }
 
@@ -455,7 +453,7 @@ impl EventMonitor {
             if r31 as u32 == address.wrapping_add(2) {
                 // JMP anywhere else, if r31 points to after the JMP, is an indirect call
                 let target = unsafe { vb_get_program_register(sim, jmp_reg as u32) };
-                return Some(SimEvent::Call(target as u32 & 0x07ffffff));
+                return Some(SimEvent::Call(target as u32));
             }
         }
 

src/emulator/shrooms_vb_util.rs

@@ -1,31 +0,0 @@
-use std::ffi::c_void;
-
-#[unsafe(no_mangle)]
-unsafe fn vbu_realloc_shim(ptr: *mut c_void, new_size: usize) -> *mut c_void {
-    if !ptr.is_null() {
-        // not supporting proper realloc because it needs bookkeeping and it's unnecessary
-        return std::ptr::null_mut();
-    }
-    let allocation = vec![0u8; new_size].into_boxed_slice();
-    Box::into_raw(allocation).cast()
-}
-
-#[link(name = "vb")]
-unsafe extern "C" {
-    #[link_name = "vbuFromISX"]
-    fn vbu_from_isx(bytes: *const c_void, length: usize, rom_length: *mut usize) -> *mut c_void;
-}
-
-pub fn rom_from_isx(bytes: &[u8]) -> Option<Vec<u8>> {
-    if !bytes.starts_with(b"ISX") {
-        return None;
-    }
-    let mut rom_length = 0;
-    let raw_rom = unsafe { vbu_from_isx(bytes.as_ptr().cast(), bytes.len(), &mut rom_length) };
-    if raw_rom.is_null() {
-        return None;
-    }
-    // SAFETY: the rom was allocated by vbu_realloc_shim, which created it from a Vec<u8>.
-    let rom = unsafe { Vec::from_raw_parts(raw_rom.cast(), rom_length, rom_length) };
-    Some(rom)
-}

src/filepicker.rs

@@ -1,56 +0,0 @@
-use std::{
-    path::PathBuf,
-    sync::{Arc, Weak},
-};
-
-use winit::window::Window;
-
-pub struct FilePicker {
-    window: Option<Weak<Window>>,
-}
-
-impl FilePicker {
-    pub fn new() -> Self {
-        Self { window: None }
-    }
-
-    pub fn set_window(&mut self, window: &Arc<Window>) {
-        self.window = Some(Arc::downgrade(window));
-    }
-
-    pub fn new_dialog(&self) -> FileDialogBuilder {
-        #[allow(unused_mut)]
-        let mut dialog = rfd::AsyncFileDialog::new();
-        #[cfg(target_os = "macos")]
-        if let Some(window) = self.window.as_ref().and_then(|w| w.upgrade()) {
-            dialog = dialog.set_parent(&window);
-        }
-        FileDialogBuilder { dialog }
-    }
-}
-
-pub struct FileDialogBuilder {
-    dialog: rfd::AsyncFileDialog,
-}
-
-impl FileDialogBuilder {
-    pub fn add_filter(self, name: impl Into<String>, extensions: &[impl ToString]) -> Self {
-        Self {
-            dialog: self.dialog.add_filter(name, extensions),
-        }
-    }
-
-    pub fn set_file_name(self, file_name: impl Into<String>) -> Self {
-        Self {
-            dialog: self.dialog.set_file_name(file_name),
-        }
-    }
-
-    pub fn pick_file(self) -> Option<PathBuf> {
-        pollster::block_on(self.dialog.pick_file()).map(Into::into)
-    }
-
-    pub fn save_file(self) -> Option<PathBuf> {
-        pollster::block_on(self.dialog.save_file()).map(Into::into)
-    }
-}

src/images.rs

@@ -1,5 +1,5 @@
 use std::{
-    collections::{HashMap, hash_map::Entry},
+    collections::HashMap,
     ops::Deref,
     sync::{Arc, Mutex, Weak},
     thread,
@@ -7,21 +7,17 @@ use std::{
 };
 
 use egui::{
-    Color32, ColorImage, TextureHandle,
+    Color32, ColorImage, TextureHandle, TextureOptions,
     epaint::ImageDelta,
-    generate_loader_id,
     load::{LoadError, SizedTexture, TextureLoader, TexturePoll},
 };
 use tokio::{sync::mpsc, time::timeout};
 
-use crate::emulator::SimId;
-
-pub struct ImageTextureLoader {
-    cache: Mutex<HashMap<String, ImageEntry>>,
+pub struct ImageProcessor {
     sender: mpsc::UnboundedSender<Box<dyn ImageRendererImpl>>,
 }
 
-impl ImageTextureLoader {
+impl ImageProcessor {
     pub fn new() -> Self {
         let (sender, receiver) = mpsc::unbounded_channel();
         thread::spawn(move || {
@@ -30,52 +26,29 @@ impl ImageTextureLoader {
                 .build()
                 .unwrap()
                 .block_on(async move {
-                    let mut worker = ImageTextureLoaderWorker {
+                    let mut worker = ImageProcessorWorker {
                         receiver,
                         renderers: vec![],
                     };
                     worker.run().await
                 })
         });
-        Self {
-            cache: Mutex::new(HashMap::new()),
-            sender,
-        }
+        Self { sender }
     }
 
     pub fn add<const N: usize, R: ImageRenderer<N> + 'static>(
         &self,
-        sim_id: SimId,
         renderer: R,
         params: R::Params,
-    ) -> ImageParams<R::Params> {
+    ) -> ([ImageHandle; N], ImageParams<R::Params>) {
         let states = renderer.sizes().map(ImageState::new);
+        let handles = states.clone().map(|state| ImageHandle {
+            size: state.size.map(|i| i as f32),
+            data: state.sink,
+        });
         let images = renderer
             .sizes()
             .map(|[width, height]| ImageBuffer::new(width, height));
-        {
-            let mut cache = self.cache.lock().unwrap();
-            for (name, state) in renderer.names().into_iter().zip(&states) {
-                let url = format!("vip://{sim_id}/{name}");
-                let entry = ImageEntry {
-                    size: state.size.map(|i| i as f32),
-                    data: Arc::downgrade(&state.sink),
-                    texture: None,
-                };
-                match cache.entry(url) {
-                    Entry::Vacant(e) => {
-                        e.insert(entry);
-                    }
-                    Entry::Occupied(mut e) => {
-                        // Only overwrite an old entry if that entry is dead.
-                        // Otherwise, we clear out the reference to a texture actually in use.
-                        if e.get().data.strong_count() == 0 {
-                            e.insert(entry);
-                        }
-                    }
-                }
-            }
-        }
         let sink = Arc::new(Mutex::new(params.clone()));
         let _ = self.sender.send(Box::new(ImageRendererWrapper {
             renderer,
@@ -83,87 +56,20 @@ impl ImageTextureLoader {
             images,
             states,
         }));
-        ImageParams {
+        let params = ImageParams {
             value: params,
             sink,
-        }
-    }
-}
-
-impl TextureLoader for ImageTextureLoader {
-    fn id(&self) -> &str {
-        generate_loader_id!(ImageTextureLoader2)
-    }
-
-    fn load(
-        &self,
-        ctx: &egui::Context,
-        uri: &str,
-        texture_options: egui::TextureOptions,
-        _size_hint: egui::SizeHint,
-    ) -> Result<TexturePoll, LoadError> {
-        let mut cache = self.cache.lock().unwrap();
-        let Some(entry) = cache.get_mut(uri) else {
-            return Err(LoadError::NotSupported);
         };
-        if texture_options != egui::TextureOptions::NEAREST {
-            return Err(LoadError::Loading(
-                "Only TextureOptions::NEAREST are supported".into(),
-            ));
-        }
-        let Some(data) = entry.data.upgrade() else {
-            cache.remove(uri);
-            return Err(LoadError::Loading("Backing loader no longer exists".into()));
-        };
-        match (data.lock().unwrap().take(), entry.texture.as_ref()) {
-            (Some(update), Some(handle)) => {
-                let delta = ImageDelta::full(update, texture_options);
-                ctx.tex_manager().write().set(handle.id(), delta);
-                let texture = SizedTexture::new(handle, entry.size);
-                Ok(TexturePoll::Ready { texture })
-            }
-            (Some(update), None) => {
-                let handle = ctx.load_texture(uri, update, texture_options);
-                let texture = SizedTexture::new(&handle, entry.size);
-                entry.texture.replace(handle);
-                Ok(TexturePoll::Ready { texture })
-            }
-            (None, Some(handle)) => {
-                let texture = SizedTexture::new(handle, entry.size);
-                Ok(TexturePoll::Ready { texture })
-            }
-            (None, None) => {
-                let size = entry.size.into();
-                Ok(TexturePoll::Pending { size: Some(size) })
-            }
-        }
-    }
-
-    fn forget(&self, uri: &str) {
-        let _ = uri;
-    }
-
-    fn forget_all(&self) {}
-
-    fn byte_size(&self) -> usize {
-        self.cache
-            .lock()
-            .unwrap()
-            .values()
-            .map(|entry| {
-                let [width, height] = entry.size;
-                width as usize * height as usize * 4
-            })
-            .sum()
+        (handles, params)
     }
 }
 
-struct ImageTextureLoaderWorker {
+struct ImageProcessorWorker {
     receiver: mpsc::UnboundedReceiver<Box<dyn ImageRendererImpl>>,
     renderers: Vec<Box<dyn ImageRendererImpl>>,
 }
 
-impl ImageTextureLoaderWorker {
+impl ImageProcessorWorker {
     async fn run(&mut self) {
         loop {
             if self.renderers.is_empty() {
@@ -236,10 +142,16 @@ impl ImageBuffer {
     }
 }
 
-struct ImageEntry {
+#[derive(Clone)]
+pub struct ImageHandle {
     size: [f32; 2],
-    data: Weak<Mutex<Option<Arc<ColorImage>>>>,
-    texture: Option<TextureHandle>,
+    data: Arc<Mutex<Option<Arc<ColorImage>>>>,
+}
+
+impl ImageHandle {
+    fn pull(&mut self) -> Option<Arc<ColorImage>> {
+        self.data.lock().unwrap().take()
+    }
 }
 
 pub struct ImageParams<T> {
@@ -266,7 +178,6 @@ impl<T: Clone + Eq> ImageParams<T> {
 
 pub trait ImageRenderer<const N: usize>: Send {
     type Params: Clone + Send;
-    fn names(&self) -> [&str; N];
     fn sizes(&self) -> [[usize; 2]; N];
     fn render(&mut self, params: &Self::Params, images: &mut [ImageBuffer; N]);
 }
@@ -335,3 +246,83 @@ impl<const N: usize, R: ImageRenderer<N> + Send> ImageRendererImpl for ImageRend
         Ok(())
     }
 }
+
+pub struct ImageTextureLoader {
+    cache: Mutex<HashMap<String, (ImageHandle, Option<TextureHandle>)>>,
+}
+
+impl ImageTextureLoader {
+    pub fn new(renderers: impl IntoIterator<Item = (String, ImageHandle)>) -> Self {
+        let mut cache = HashMap::new();
+        for (key, image) in renderers {
+            cache.insert(key, (image, None));
+        }
+        Self {
+            cache: Mutex::new(cache),
+        }
+    }
+}
+
+impl TextureLoader for ImageTextureLoader {
+    fn id(&self) -> &str {
+        concat!(module_path!(), "ImageTextureLoader")
+    }
+
+    fn load(
+        &self,
+        ctx: &egui::Context,
+        uri: &str,
+        texture_options: TextureOptions,
+        _size_hint: egui::SizeHint,
+    ) -> Result<TexturePoll, LoadError> {
+        let mut cache = self.cache.lock().unwrap();
+        let Some((image, maybe_handle)) = cache.get_mut(uri) else {
+            return Err(LoadError::NotSupported);
+        };
+        if texture_options != TextureOptions::NEAREST {
+            return Err(LoadError::Loading(
+                "Only TextureOptions::NEAREST are supported".into(),
+            ));
+        }
+        match (image.pull(), maybe_handle.as_ref()) {
+            (Some(update), Some(handle)) => {
+                let delta = ImageDelta::full(update, texture_options);
+                ctx.tex_manager().write().set(handle.id(), delta);
+                let texture = SizedTexture::new(handle, image.size);
+                Ok(TexturePoll::Ready { texture })
+            }
+            (Some(update), None) => {
+                let handle = ctx.load_texture(uri, update, texture_options);
+                let texture = SizedTexture::new(&handle, image.size);
+                maybe_handle.replace(handle);
+                Ok(TexturePoll::Ready { texture })
+            }
+            (None, Some(handle)) => {
+                let texture = SizedTexture::new(handle, image.size);
+                Ok(TexturePoll::Ready { texture })
+            }
+            (None, None) => {
+                let size = image.size.into();
+                Ok(TexturePoll::Pending { size: Some(size) })
+            }
+        }
+    }
+
+    fn forget(&self, uri: &str) {
+        let _ = uri;
+    }
+
+    fn forget_all(&self) {}
+
+    fn byte_size(&self) -> usize {
+        self.cache
+            .lock()
+            .unwrap()
+            .values()
+            .map(|(image, _)| {
+                let [width, height] = image.size;
+                width as usize * height as usize * 4
+            })
+            .sum()
+    }
+}

src/input.rs

@@ -52,28 +52,12 @@ pub trait Mappings {
     fn use_default_mappings(&mut self);
 }
 
-#[derive(Clone, Copy, Serialize, Deserialize)]
-pub struct AxisMapping {
-    pub neg: VBKey,
-    pub pos: VBKey,
-    pub pair: Option<Code>,
-}
-impl Default for AxisMapping {
-    fn default() -> Self {
-        Self {
-            neg: VBKey::empty(),
-            pos: VBKey::empty(),
-            pair: None,
-        }
-    }
-}
-
 #[derive(Serialize, Deserialize)]
 pub struct GamepadMapping {
     buttons: HashMap<Code, VBKey>,
-    axes: HashMap<Code, AxisMapping>,
+    axes: HashMap<Code, (VBKey, VBKey)>,
     default_buttons: HashMap<Code, VBKey>,
-    default_axes: HashMap<Code, AxisMapping>,
+    default_axes: HashMap<Code, (VBKey, VBKey)>,
 }
 
 impl GamepadMapping {
@@ -94,8 +78,7 @@ impl GamepadMapping {
         let mut default_axes = HashMap::new();
         let mut default_axis = |axis: Axis, neg: VBKey, pos: VBKey| {
             if let Some(code) = gamepad.axis_code(axis) {
-                let pair = axis.second_axis().and_then(|a| gamepad.axis_code(a));
-                default_axes.insert(code, AxisMapping { neg, pos, pair });
+                default_axes.insert(code, (neg, pos));
             }
         };
         default_axis(Axis::LeftStickX, VBKey::LL, VBKey::LR);
@@ -119,13 +102,19 @@ impl GamepadMapping {
     }
 
     pub fn add_axis_neg_mapping(&mut self, key: VBKey, code: Code) {
-        let entry = self.axes.entry(code).or_default();
-        entry.neg = entry.neg.union(key);
+        let entry = self
+            .axes
+            .entry(code)
+            .or_insert((VBKey::empty(), VBKey::empty()));
+        entry.0 = entry.0.union(key);
     }
 
     pub fn add_axis_pos_mapping(&mut self, key: VBKey, code: Code) {
-        let entry = self.axes.entry(code).or_default();
-        entry.pos = entry.pos.union(key);
+        let entry = self
+            .axes
+            .entry(code)
+            .or_insert((VBKey::empty(), VBKey::empty()));
+        entry.1 = entry.1.union(key);
     }
 
     fn save_mappings(&self) -> PersistedGamepadMapping {
@@ -156,11 +145,11 @@ impl GamepadMapping {
 impl Mappings for GamepadMapping {
     fn mapping_names(&self) -> HashMap<VBKey, Vec<String>> {
         let mut results: HashMap<VBKey, Vec<String>> = HashMap::new();
-        for (axis, mapping) in &self.axes {
-            for key in mapping.neg.iter() {
+        for (axis, (left_keys, right_keys)) in &self.axes {
+            for key in left_keys.iter() {
                 results.entry(key).or_default().push(format!("-{axis}"));
             }
-            for key in mapping.pos.iter() {
+            for key in right_keys.iter() {
                 results.entry(key).or_default().push(format!("+{axis}"));
             }
         }
@@ -173,10 +162,10 @@ impl Mappings for GamepadMapping {
     }
 
     fn clear_mappings(&mut self, key: VBKey) {
-        self.axes.retain(|_, mapping| {
-            mapping.neg = mapping.neg.difference(key);
-            mapping.pos = mapping.pos.difference(key);
-            !(mapping.neg.is_empty() && mapping.pos.is_empty())
+        self.axes.retain(|_, (left, right)| {
+            *left = left.difference(key);
+            *right = right.difference(key);
+            !(left.is_empty() && right.is_empty())
         });
         self.buttons.retain(|_, keys| {
             *keys = keys.difference(key);
@@ -211,7 +200,7 @@ impl InputMapping {
         mappings.buttons.get(code).copied()
     }
 
-    pub fn map_axis(&self, id: &GamepadId, code: &Code) -> Option<AxisMapping> {
+    pub fn map_axis(&self, id: &GamepadId, code: &Code) -> Option<(VBKey, VBKey)> {
         let mappings = self.gamepads.get(id)?.read().unwrap();
         mappings.axes.get(code).copied()
     }
@@ -283,14 +272,13 @@ impl Mappings for InputMapping {
 #[derive(Clone)]
 pub struct MappingProvider {
     persistence: Persistence,
-    first_gamepad_is_p2: bool,
     device_mappings: Arc<RwLock<HashMap<DeviceId, Arc<RwLock<GamepadMapping>>>>>,
     sim_mappings: HashMap<SimId, Arc<RwLock<InputMapping>>>,
     gamepad_info: Arc<RwLock<HashMap<GamepadId, GamepadInfo>>>,
 }
 
 impl MappingProvider {
-    pub fn new(persistence: Persistence, first_gamepad_is_p2: bool) -> Self {
+    pub fn new(persistence: Persistence) -> Self {
         let mut sim_mappings = HashMap::new();
         let mut device_mappings = HashMap::new();
 
@@ -319,7 +307,6 @@ impl MappingProvider {
             device_mappings: Arc::new(RwLock::new(device_mappings)),
             gamepad_info: Arc::new(RwLock::new(HashMap::new())),
             sim_mappings,
-            first_gamepad_is_p2,
         }
     }
 
@@ -351,12 +338,7 @@ impl MappingProvider {
         .clone();
         drop(lock);
         let mut lock = self.gamepad_info.write().unwrap();
-        let players = if self.first_gamepad_is_p2 {
-            vec![SimId::Player2, SimId::Player1]
-        } else {
-            vec![SimId::Player1, SimId::Player2]
-        };
-        let bound_to = players
+        let bound_to = SimId::values()
             .into_iter()
             .find(|sim_id| lock.values().all(|info| info.bound_to != Some(*sim_id)));
         if let Entry::Vacant(entry) = lock.entry(gamepad.id()) {
@@ -470,15 +452,20 @@ struct PersistedKeyboardMapping {
 #[derive(Serialize, Deserialize)]
 struct PersistedGamepadMapping {
     buttons: Vec<(Code, VBKey)>,
-    axes: Vec<(Code, AxisMapping)>,
+    axes: Vec<(Code, (VBKey, VBKey))>,
     default_buttons: Vec<(Code, VBKey)>,
-    default_axes: Vec<(Code, AxisMapping)>,
+    default_axes: Vec<(Code, (VBKey, VBKey))>,
+}
+
+#[derive(Serialize, Deserialize)]
+pub struct Shortcut {
+    pub shortcut: KeyboardShortcut,
+    pub command: Command,
 }
 
 #[derive(Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Hash)]
 pub enum Command {
     OpenRom,
-    ReloadRom,
     Quit,
     FrameAdvance,
     FastForward(u32),
@@ -489,10 +476,9 @@ pub enum Command {
 }
 
 impl Command {
-    pub fn all() -> [Self; 8] {
+    pub fn all() -> [Self; 7] {
         [
             Self::OpenRom,
-            Self::ReloadRom,
             Self::Quit,
             Self::PauseResume,
             Self::Reset,
@@ -505,7 +491,6 @@ impl Command {
     pub fn name(self) -> &'static str {
         match self {
             Self::OpenRom => "Open ROM",
-            Self::ReloadRom => "Reload ROM",
             Self::Quit => "Exit",
             Self::PauseResume => "Pause/Resume",
             Self::Reset => "Reset",
@@ -537,10 +522,6 @@ impl Default for Shortcuts {
             Command::OpenRom,
             KeyboardShortcut::new(Modifiers::COMMAND, Key::O),
         );
-        shortcuts.set(
-            Command::ReloadRom,
-            KeyboardShortcut::new(Modifiers::COMMAND | Modifiers::SHIFT, Key::F5),
-        );
         shortcuts.set(
             Command::Quit,
             KeyboardShortcut::new(Modifiers::COMMAND, Key::Q),
@@ -701,7 +682,7 @@ impl ShortcutProvider {
                 else {
                     return true;
                 };
-                if *key != shortcut.logical_key || !modifiers.contains(shortcut.modifiers) {
+                if shortcut.logical_key != *key || !shortcut.modifiers.contains(*modifiers) {
                     return true;
                 }
                 if matches!(command, Command::FastForward(_)) {

src/main.rs

@@ -1,7 +1,7 @@
 // hide console in release mode
 #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]
 
-use std::{process, time::SystemTime};
+use std::{path::PathBuf, process, time::SystemTime};
 
 use anyhow::{Result, bail};
 use app::Application;
@@ -12,18 +12,10 @@ use tracing::error;
 use tracing_subscriber::{EnvFilter, Layer, layer::SubscriberExt, util::SubscriberInitExt};
 use winit::event_loop::{ControlFlow, EventLoop};
 
-use crate::{
-    config::{AppConfig, CliArgs, SimConfig},
-    emulator::SimId,
-    persistence::Persistence,
-};
-
 mod app;
 mod audio;
-mod config;
 mod controller;
 mod emulator;
-mod filepicker;
 mod gdbserver;
 mod graphics;
 mod images;
@@ -33,6 +25,18 @@ mod persistence;
 mod profiler;
 mod window;
 
+#[derive(Parser)]
+struct Args {
+    /// The path to a virtual boy ROM to run.
+    rom: Option<PathBuf>,
+    /// Start a GDB/LLDB debug server on this port.
+    #[arg(short, long)]
+    debug_port: Option<u16>,
+    /// Enable profiling a game
+    #[arg(short, long)]
+    profile: bool,
+}
+
 fn init_logger() {
     let directives = std::env::var("RUST_LOG").unwrap_or("error,lemur=info".into());
     let filter = EnvFilter::builder().parse_lossy(directives);
@@ -94,9 +98,7 @@ fn main() -> Result<()> {
     #[cfg(windows)]
     set_process_priority_to_high()?;
 
-    let args = CliArgs::parse();
-
-    let persistence = Persistence::new();
+    let args = Args::parse();
 
     let (mut builder, client) = EmulatorBuilder::new();
     if let Some(path) = &args.rom {
@@ -111,18 +113,6 @@ fn main() -> Result<()> {
     if args.profile {
         builder = builder.start_paused(true)
     }
-    let mut config = AppConfig::load(&persistence);
-    if config.update(&args) {
-        let _ = config.save(&persistence);
-    }
-    let p1 = SimConfig::load(&persistence, SimId::Player1);
-    let p2 = SimConfig::load(&persistence, SimId::Player2);
-
-    let watch = args.watch;
-
-    builder = builder
-        .with_audio_on(p1.audio_enabled, p2.audio_enabled)
-        .with_watch_rom(watch, watch);
 
     ThreadBuilder::default()
         .name("Emulator".to_owned())
@@ -141,14 +131,11 @@ fn main() -> Result<()> {
     let event_loop = EventLoop::with_user_event().build().unwrap();
     event_loop.set_control_flow(ControlFlow::Poll);
     let proxy = event_loop.create_proxy();
-    let handle = event_loop.owned_display_handle();
     event_loop.run_app(&mut Application::new(
         client,
         proxy,
-        handle,
-        persistence,
-        args,
-        config,
+        args.debug_port,
+        args.profile,
     ))?;
     Ok(())
 }

src/memory.rs

@@ -50,11 +50,11 @@ impl MemoryClient {
 }
 
 fn aligned_memory(start: u32, length: usize) -> BoxBytes {
-    if start.is_multiple_of(4) && length.is_multiple_of(4) {
+    if start % 4 == 0 && length % 4 == 0 {
         let memory = vec![0u32; length / 4].into_boxed_slice();
         return bytemuck::box_bytes_of(memory);
     }
-    if start.is_multiple_of(2) && length.is_multiple_of(2) {
+    if start % 2 == 0 && length % 2 == 0 {
         let memory = vec![0u16; length / 2].into_boxed_slice();
         return bytemuck::box_bytes_of(memory);
     }

src/profiler/state.rs

@@ -60,11 +60,6 @@ impl ProgramState {
         let Some(stack) = self.call_stacks.get_mut(code) else {
             bail!("missing stack {code:04x}");
         };
-        // just popping the inline frames first
-        while stack
-            .pop_if(|f| matches!(f, StackFrame::Label(_)))
-            .is_some()
-        {}
         if stack.pop().is_none() {
             bail!("returned from {code:04x} but stack was empty");
         }

src/window.rs

@@ -1,9 +1,6 @@
-use std::sync::Arc;
-
 pub use about::AboutWindow;
-use egui::{Ui, ViewportBuilder};
-pub use game::{ChildWindow, GameWindow};
-pub use game_screen::{DisplayMode, GameScreen};
+use egui::{Context, ViewportBuilder, ViewportId};
+pub use game::GameWindow;
 pub use gdb::GdbServerWindow;
 pub use hotkeys::HotkeysWindow;
 pub use input::InputWindow;
@@ -12,7 +9,7 @@ pub use terminal::TerminalWindow;
 pub use vip::{
     BgMapWindow, CharacterDataWindow, FrameBufferWindow, ObjectWindow, RegisterWindow, WorldWindow,
 };
-use winit::{event::KeyEvent, window::Window};
+use winit::event::KeyEvent;
 
 use crate::emulator::SimId;
 
@@ -28,17 +25,17 @@ mod utils;
 mod vip;
 
 pub trait AppWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        None
-    }
-    fn image_url(&self, name: &str) -> String {
-        format!("vip://{}/{name}", self.sim_id().unwrap_or(SimId::Player1))
+    fn viewport_id(&self) -> ViewportId;
+    fn sim_id(&self) -> SimId {
+        SimId::Player1
     }
     fn initial_viewport(&self) -> ViewportBuilder;
-    fn show(&mut self, ui: &mut Ui);
-    fn on_init(&mut self, args: InitArgs) {
-        let _ = args;
+    fn show(&mut self, ctx: &Context);
+    fn on_init(&mut self, ctx: &Context, render_state: &egui_wgpu::RenderState) {
+        let _ = ctx;
+        let _ = render_state;
     }
+    fn on_destroy(&mut self) {}
     fn handle_key_event(&mut self, event: &KeyEvent) -> bool {
         let _ = event;
         false
@@ -48,8 +45,3 @@ pub trait AppWindow {
         false
     }
 }
-
-pub struct InitArgs<'a> {
-    pub window: &'a Arc<Window>,
-    pub render_state: &'a egui_wgpu::RenderState,
-}

src/window/about.rs

@@ -1,18 +1,22 @@
-use egui::{CentralPanel, Image, Ui, ViewportBuilder};
+use egui::{CentralPanel, Context, Image, ViewportBuilder, ViewportId};
 
 use super::AppWindow;
 
 pub struct AboutWindow;
 
 impl AppWindow for AboutWindow {
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of("About")
+    }
+
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
             .with_title("About Lemur")
             .with_inner_size((300.0, 200.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.vertical_centered(|ui| {
                 ui.label("Lemur Virtual Boy Emulator");
                 ui.label(format!("Version {}", env!("CARGO_PKG_VERSION")));

src/window/game.rs

@@ -1,32 +1,19 @@
-use std::{
-    ops::{Deref, DerefMut},
-    sync::{Arc, Mutex, atomic::AtomicBool, mpsc},
-    time::Duration,
-};
+use std::{sync::mpsc, time::Duration};
 
 use crate::{
     app::UserEvent,
-    config::{COLOR_PRESETS, SimConfig},
     emulator::{EmulatorClient, EmulatorCommand, EmulatorState, SimId, SimState},
-    filepicker::FilePicker,
-    images::ImageTextureLoader,
-    input::{Command, MappingProvider, ShortcutProvider},
-    memory::MemoryClient,
+    input::{Command, ShortcutProvider},
     persistence::Persistence,
-    window::{
-        AboutWindow, BgMapWindow, CharacterDataWindow, FrameBufferWindow, GdbServerWindow,
-        HotkeysWindow, InitArgs, InputWindow, ObjectWindow, ProfileWindow, RegisterWindow,
-        TerminalWindow, WorldWindow, utils::UiData,
-    },
 };
 use anyhow::Context as _;
 use egui::{
-    Align2, Button, CentralPanel, Color32, Context, Frame, MenuBar, Panel, Pos2, Ui, Vec2,
-    ViewportBuilder, ViewportCommand, ViewportId, ViewportIdMap, Window,
+    Align2, Button, CentralPanel, Color32, Context, Frame, MenuBar, TopBottomPanel, Ui, Vec2,
+    ViewportBuilder, ViewportCommand, ViewportId, Window,
 };
 use egui_notify::{Anchor, Toast, Toasts};
 use serde::{Deserialize, Serialize};
-use winit::{event::KeyEvent, event_loop::EventLoopProxy};
+use winit::event_loop::EventLoopProxy;
 
 use super::{
     AppWindow,
@@ -34,50 +21,48 @@ use super::{
     utils::UiExt as _,
 };
 
+const COLOR_PRESETS: [[Color32; 2]; 3] = [
+    [
+        Color32::from_rgb(0xff, 0x00, 0x00),
+        Color32::from_rgb(0x00, 0xc6, 0xf0),
+    ],
+    [
+        Color32::from_rgb(0x00, 0xb4, 0x00),
+        Color32::from_rgb(0xc8, 0x00, 0xff),
+    ],
+    [
+        Color32::from_rgb(0xb4, 0x9b, 0x00),
+        Color32::from_rgb(0x00, 0x00, 0xff),
+    ],
+];
+
 pub struct GameWindow {
-    viewport_id: ViewportId,
     client: EmulatorClient,
     proxy: EventLoopProxy<UserEvent>,
     persistence: Persistence,
     shortcuts: ShortcutProvider,
     sim_id: SimId,
-    config: SimConfig,
+    config: GameConfig,
     toasts: Toasts,
     screen: Option<GameScreen>,
-    messages: mpsc::Receiver<Toast>,
-    message_sink: mpsc::Sender<Toast>,
+    messages: Option<mpsc::Receiver<Toast>>,
     color_picker: Option<ColorPickerState>,
-    file_picker: FilePicker,
-    memory: Arc<MemoryClient>,
-    images: Arc<ImageTextureLoader>,
-    mappings: MappingProvider,
-    children: ViewportIdMap<ChildWindowWrapper>,
-    child_states: UiData<ViewportIdMap<ChildState>>,
-    queued_children: Vec<ChildWindow>,
-    show_player_name: bool,
 }
 
 impl GameWindow {
-    #[expect(clippy::too_many_arguments)]
     pub fn new(
-        viewport_id: ViewportId,
         client: EmulatorClient,
         proxy: EventLoopProxy<UserEvent>,
         persistence: Persistence,
         shortcuts: ShortcutProvider,
-        memory: &Arc<MemoryClient>,
-        images: &Arc<ImageTextureLoader>,
-        mappings: MappingProvider,
         sim_id: SimId,
     ) -> Self {
-        let config = SimConfig::load(&persistence, sim_id);
+        let config = load_config(&persistence, sim_id);
         let toasts = Toasts::new()
             .with_anchor(Anchor::BottomLeft)
             .with_margin((10.0, 10.0).into())
             .reverse(true);
-        let (message_sink, messages) = mpsc::channel();
         Self {
-            viewport_id,
             client,
             proxy,
             persistence,
@@ -86,161 +71,12 @@ impl GameWindow {
             config,
             toasts,
             screen: None,
-            messages,
-            message_sink,
+            messages: None,
             color_picker: None,
-            file_picker: FilePicker::new(),
-            memory: memory.clone(),
-            images: images.clone(),
-            mappings: mappings.clone(),
-            children: ViewportIdMap::default(),
-            child_states: UiData::new(),
-            queued_children: vec![],
-            show_player_name: false,
         }
     }
 
-    pub fn open(&mut self, window: ChildWindow) {
-        // queue opening this child until our next render call,
-        // so that we get a chance to look up its size
-        self.queued_children.push(window);
-    }
-
-    pub fn close(&mut self, window: ChildWindow) {
-        let id = window.viewport_id(self.sim_id);
-        self.children.remove(&id);
-    }
-
-    fn do_open(&mut self, window: ChildWindow) {
-        let viewport_id = window.viewport_id(self.sim_id);
-        if self.children.contains_key(&viewport_id) {
-            return;
-        }
-        let child = match window {
-            ChildWindow::About => AppWrapper::of_dyn(AboutWindow),
-            ChildWindow::CharacterData => AppWrapper::of_dyn(CharacterDataWindow::new(
-                self.sim_id,
-                &self.memory,
-                &self.images,
-            )),
-            ChildWindow::BgMap => {
-                AppWrapper::of_dyn(BgMapWindow::new(self.sim_id, &self.memory, &self.images))
-            }
-            ChildWindow::Objects => {
-                AppWrapper::of_dyn(ObjectWindow::new(self.sim_id, &self.memory, &self.images))
-            }
-            ChildWindow::Worlds => {
-                AppWrapper::of_dyn(WorldWindow::new(self.sim_id, &self.memory, &self.images))
-            }
-            ChildWindow::FrameBuffers => AppWrapper::of_dyn(FrameBufferWindow::new(
-                self.sim_id,
-                &self.memory,
-                &self.images,
-            )),
-            ChildWindow::Registers => {
-                AppWrapper::of_dyn(RegisterWindow::new(self.sim_id, &self.memory))
-            }
-            ChildWindow::Terminal => {
-                AppWrapper::of_dyn(TerminalWindow::new(self.sim_id, &self.client))
-            }
-            ChildWindow::Profiler { launch } => {
-                let mut profile = ProfileWindow::new(self.sim_id, self.client.clone());
-                if launch {
-                    profile.launch();
-                }
-                AppWrapper::of_dyn(profile)
-            }
-            ChildWindow::Debugger { port } => {
-                let mut debugger =
-                    GdbServerWindow::new(self.sim_id, self.client.clone(), self.proxy.clone());
-                if let Some(port) = port {
-                    debugger.launch(port);
-                }
-                AppWrapper::of_dyn(debugger)
-            }
-            ChildWindow::Input => AppWrapper::of_dyn(InputWindow::new(self.mappings.clone())),
-            ChildWindow::Hotkeys => AppWrapper::of_dyn(HotkeysWindow::new(self.shortcuts.clone())),
-            ChildWindow::Player2 => {
-                if self.sim_id == SimId::Player2 {
-                    return;
-                }
-                AppWrapper::of_game(GameWindow::new(
-                    viewport_id,
-                    self.client.clone(),
-                    self.proxy.clone(),
-                    self.persistence.clone(),
-                    self.shortcuts.clone(),
-                    &self.memory,
-                    &self.images,
-                    self.mappings.clone(),
-                    SimId::Player2,
-                ))
-            }
-        };
-
-        let mut viewport = child.initial_viewport();
-        let title = viewport.title.clone().unwrap();
-        let sim_id = child.sim_id();
-        if let Some(sim_id) = sim_id
-            && self.show_player_name
-        {
-            viewport.title = Some(format!("{title} ({sim_id})"));
-        }
-        if let Some(state) = self.child_states.get(&viewport_id) {
-            viewport.position = Some(state.position);
-            viewport.inner_size = Some(state.size);
-        }
-        self.children.insert(
-            viewport_id,
-            ChildWindowWrapper {
-                app: Arc::new(Mutex::new(child)),
-                title,
-                sim_id,
-                updates: Some(viewport),
-                close_requested: Arc::new(AtomicBool::new(false)),
-            },
-        );
-    }
-
-    pub fn handle_init(&mut self, viewport_id: ViewportId, args: InitArgs) {
-        self.handle_event(viewport_id, |window| window.on_init(args))
-    }
-
-    pub fn handle_key_event(&mut self, viewport_id: ViewportId, event: &KeyEvent) -> bool {
-        self.handle_event(viewport_id, |window| window.handle_key_event(event))
-    }
-
-    pub fn handle_gamepad_event(&mut self, viewport_id: ViewportId, event: &gilrs::Event) -> bool {
-        self.handle_event(viewport_id, |window| window.handle_gamepad_event(event))
-    }
-
-    fn handle_event<F, R>(&mut self, viewport_id: ViewportId, cb: F) -> R
-    where
-        F: FnOnce(&mut dyn AppWindow) -> R,
-        R: Default,
-    {
-        let p2_viewport_id = ChildWindow::Player2.viewport_id(SimId::Player1);
-
-        if self.viewport_id == viewport_id {
-            cb(self)
-        } else if let Some(child) = self.children.get_mut(&viewport_id) {
-            cb(child.app.lock().unwrap().deref_mut().deref_mut())
-        } else if let Some(mut p2) = self
-            .children
-            .get_mut(&p2_viewport_id)
-            .map(|w| w.app.lock().unwrap())
-        {
-            if let AppWrapper::Game(g) = p2.deref_mut() {
-                g.handle_event(viewport_id, cb)
-            } else {
-                R::default()
-            }
-        } else {
-            R::default()
-        }
-    }
-
-    fn show_menu(&mut self, ui: &mut Ui) {
+    fn show_menu(&mut self, ctx: &Context, ui: &mut Ui) {
         let state = self.client.emulator_state();
         let is_ready = self.client.sim_state(self.sim_id) == SimState::Ready;
         let can_pause = is_ready && state == EmulatorState::Running;
@@ -250,20 +86,14 @@ impl GameWindow {
         for command in ui.input_mut(|input| self.shortcuts.consume_all(input)) {
             match command {
                 Command::OpenRom => {
-                    let rom = self
-                        .file_picker
-                        .new_dialog()
-                        .add_filter("Virtual Boy ROMs", &["vb", "vbrom", "elf", "isx"])
+                    let rom = rfd::FileDialog::new()
+                        .add_filter("Virtual Boy ROMs", &["vb", "vbrom"])
                         .pick_file();
                     if let Some(path) = rom {
                         self.client
                             .send_command(EmulatorCommand::LoadGame(self.sim_id, path));
                     }
                 }
-                Command::ReloadRom => {
-                    self.client
-                        .send_command(EmulatorCommand::ReloadRom(self.sim_id));
-                }
                 Command::Quit => {
                     let _ = self.proxy.send_event(UserEvent::Quit(self.sim_id));
                 }
@@ -308,28 +138,14 @@ impl GameWindow {
                 .add(self.button_for(ui.ctx(), "Open ROM", Command::OpenRom))
                 .clicked()
             {
-                let rom = self
-                    .file_picker
-                    .new_dialog()
-                    .add_filter("Virtual Boy ROMs", &["vb", "vbrom", "elf", "isx"])
+                let rom = rfd::FileDialog::new()
+                    .add_filter("Virtual Boy ROMs", &["vb", "vbrom"])
                     .pick_file();
                 if let Some(path) = rom {
                     self.client
                         .send_command(EmulatorCommand::LoadGame(self.sim_id, path));
                 }
             }
-            if ui
-                .add(self.button_for(ui.ctx(), "Reload ROM", Command::ReloadRom))
-                .clicked()
-            {
-                self.client
-                    .send_command(EmulatorCommand::ReloadRom(self.sim_id));
-            }
-            let watch_rom = self.client.is_rom_watched(self.sim_id);
-            if ui.selectable_button(watch_rom, "Watch ROM").clicked() {
-                self.client
-                    .send_command(EmulatorCommand::WatchRom(self.sim_id, !watch_rom));
-            }
             if ui
                 .add(self.button_for(ui.ctx(), "Quit", Command::Quit))
                 .clicked()
@@ -385,16 +201,16 @@ impl GameWindow {
                 pollster::block_on(self.take_screenshot());
             }
         });
-        ui.menu_button("Options", |ui| self.show_options_menu(ui));
+        ui.menu_button("Options", |ui| self.show_options_menu(ctx, ui));
         ui.menu_button("Multiplayer", |ui| {
-            let has_player_2 = self.client.has_player_2();
+            let has_player_2 = self.client.sim_state(SimId::Player2) != SimState::Uninitialized;
             if self.sim_id == SimId::Player1
                 && !has_player_2
                 && ui.button("Open Player 2").clicked()
             {
                 self.client
                     .send_command(EmulatorCommand::StartSecondSim(None));
-                self.open(ChildWindow::Player2);
+                self.proxy.send_event(UserEvent::OpenPlayer2).unwrap();
             }
             if has_player_2 {
                 let linked = self.client.are_sims_linked();
@@ -408,37 +224,55 @@ impl GameWindow {
         });
         ui.menu_button("Tools", |ui| {
             if ui.button("Terminal").clicked() {
-                self.open(ChildWindow::Terminal);
+                self.proxy
+                    .send_event(UserEvent::OpenTerminal(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Profiler").clicked() {
-                self.open(ChildWindow::Profiler { launch: false });
+                self.proxy
+                    .send_event(UserEvent::OpenProfiler(self.sim_id))
+                    .unwrap();
             }
             if ui.button("GDB Server").clicked() {
-                self.open(ChildWindow::Debugger { port: None });
+                self.proxy
+                    .send_event(UserEvent::OpenDebugger(self.sim_id))
+                    .unwrap();
             }
             ui.separator();
             if ui.button("Character Data").clicked() {
-                self.open(ChildWindow::CharacterData);
+                self.proxy
+                    .send_event(UserEvent::OpenCharacterData(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Background Maps").clicked() {
-                self.open(ChildWindow::BgMap);
+                self.proxy
+                    .send_event(UserEvent::OpenBgMap(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Objects").clicked() {
-                self.open(ChildWindow::Objects);
+                self.proxy
+                    .send_event(UserEvent::OpenObjects(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Worlds").clicked() {
-                self.open(ChildWindow::Worlds);
+                self.proxy
+                    .send_event(UserEvent::OpenWorlds(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Frame Buffers").clicked() {
-                self.open(ChildWindow::FrameBuffers);
+                self.proxy
+                    .send_event(UserEvent::OpenFrameBuffers(self.sim_id))
+                    .unwrap();
             }
             if ui.button("Registers").clicked() {
-                self.open(ChildWindow::Registers);
+                self.proxy
+                    .send_event(UserEvent::OpenRegisters(self.sim_id))
+                    .unwrap();
             }
         });
         ui.menu_button("Help", |ui| {
             if ui.button("About").clicked() {
-                self.open(ChildWindow::About);
+                self.proxy.send_event(UserEvent::OpenAbout).unwrap();
             }
         });
     }
@@ -464,9 +298,7 @@ impl GameWindow {
         self.client
             .send_command(EmulatorCommand::Screenshot(self.sim_id, tx));
         let bytes = rx.await.context("Could not take screenshot")?;
-        let file = self
-            .file_picker
-            .new_dialog()
+        let file = rfd::FileDialog::new()
             .add_filter("PNG images", &["png"])
             .set_file_name("screenshot.png")
             .save_file();
@@ -486,7 +318,7 @@ impl GameWindow {
         Ok(Some(path.display().to_string()))
     }
 
-    fn show_options_menu(&mut self, ui: &mut Ui) {
+    fn show_options_menu(&mut self, ctx: &Context, ui: &mut Ui) {
         ui.menu_button("Video", |ui| {
             ui.menu_button("Screen Size", |ui| {
                 let current_dims = self.config.dimensions;
@@ -502,7 +334,7 @@ impl GameWindow {
                         .selectable_button((current_dims - dims).length() < 1.0, label)
                         .clicked()
                     {
-                        ui.send_viewport_cmd(ViewportCommand::InnerSize(dims));
+                        ctx.send_viewport_cmd(ViewportCommand::InnerSize(dims));
                     }
                 }
             });
@@ -532,7 +364,7 @@ impl GameWindow {
                 let new_proportions = display_mode.proportions();
                 let scale = new_proportions / old_proportions;
                 if scale != Vec2::new(1.0, 1.0) {
-                    ui.send_viewport_cmd(ViewportCommand::InnerSize(current_dims * scale));
+                    ctx.send_viewport_cmd(ViewportCommand::InnerSize(current_dims * scale));
                 }
 
                 self.update_config(|c| {
@@ -569,24 +401,24 @@ impl GameWindow {
             });
         });
         ui.menu_button("Audio", |ui| {
-            if ui
-                .selectable_button(self.config.audio_enabled, "Enabled")
-                .clicked()
-            {
-                self.update_config(|c| c.audio_enabled = !c.audio_enabled);
-                self.client.send_command(EmulatorCommand::SetAudioEnabled(
-                    self.sim_id,
-                    self.config.audio_enabled,
-                ));
+            let p1_enabled = self.client.is_audio_enabled(SimId::Player1);
+            let p2_enabled = self.client.is_audio_enabled(SimId::Player2);
+            if ui.selectable_button(p1_enabled, "Player 1").clicked() {
+                self.client
+                    .send_command(EmulatorCommand::SetAudioEnabled(!p1_enabled, p2_enabled));
+            }
+            if ui.selectable_button(p2_enabled, "Player 2").clicked() {
+                self.client
+                    .send_command(EmulatorCommand::SetAudioEnabled(p1_enabled, !p2_enabled));
             }
         });
         ui.menu_button("Input", |ui| {
             if ui.button("Bind Inputs").clicked() {
-                self.open(ChildWindow::Input);
+                self.proxy.send_event(UserEvent::OpenInput).unwrap();
             }
         });
         if ui.button("Hotkeys").clicked() {
-            self.open(ChildWindow::Hotkeys);
+            self.proxy.send_event(UserEvent::OpenHotkeys).unwrap();
         }
     }
 
@@ -619,11 +451,13 @@ impl GameWindow {
         }
     }
 
-    fn update_config(&mut self, update: impl FnOnce(&mut SimConfig)) {
+    fn update_config(&mut self, update: impl FnOnce(&mut GameConfig)) {
         let mut new_config = self.config.clone();
         update(&mut new_config);
         if self.config != new_config {
-            let _ = new_config.save(&self.persistence, self.sim_id);
+            let _ = self
+                .persistence
+                .save_config(config_filename(self.sim_id), &new_config);
         }
         self.config = new_config;
     }
@@ -637,66 +471,59 @@ impl GameWindow {
     }
 }
 
+fn config_filename(sim_id: SimId) -> &'static str {
+    match sim_id {
+        SimId::Player1 => "config_p1",
+        SimId::Player2 => "config_p2",
+    }
+}
+
+fn load_config(persistence: &Persistence, sim_id: SimId) -> GameConfig {
+    if let Ok(config) = persistence.load_config(config_filename(sim_id)) {
+        return config;
+    }
+    GameConfig {
+        display_mode: DisplayMode::Anaglyph,
+        colors: COLOR_PRESETS[0],
+        dimensions: DisplayMode::Anaglyph.proportions() + Vec2::new(0.0, 22.0),
+    }
+}
+
 impl AppWindow for GameWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        match self.sim_id {
+            SimId::Player1 => ViewportId::ROOT,
+            SimId::Player2 => ViewportId::from_hash_of("Player2"),
+        }
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
-        let builder = ViewportBuilder::default()
+        ViewportBuilder::default()
             .with_title("Lemur")
-            .with_inner_size(self.config.dimensions);
-        if let Some(position) = self.config.position {
-            builder.with_position(position)
-        } else {
-            builder
-        }
+            .with_inner_size(self.config.dimensions)
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        let has_player_2 = self.client.has_player_2();
-        if !self.show_player_name && has_player_2 {
-            ui.send_viewport_cmd(ViewportCommand::Title(format!("Lemur ({})", self.sim_id)));
-            for (viewport_id, child) in &self.children {
-                if let Some(sim_id) = child.sim_id {
-                    ui.send_viewport_cmd_to(
-                        *viewport_id,
-                        ViewportCommand::Title(format!("{} ({sim_id})", child.title)),
-                    );
-                }
-            }
-            self.show_player_name = true;
-        } else if self.show_player_name && !has_player_2 {
-            ui.send_viewport_cmd(ViewportCommand::Title("Lemur".to_string()));
-            for (viewport_id, child) in &self.children {
-                if child.sim_id.is_some() {
-                    ui.send_viewport_cmd_to(
-                        *viewport_id,
-                        ViewportCommand::Title(child.title.clone()),
-                    );
-                }
-            }
-            self.show_player_name = false;
-        }
-        self.child_states.load(ui);
+    fn show(&mut self, ctx: &Context) {
         let dimensions = {
-            let bounds = ui.content_rect();
+            let bounds = ctx.available_rect();
             bounds.max - bounds.min
         };
-        let position = ui.input(|i| i.viewport().outer_rect.map(|r| r.min));
-        self.update_config(|c| {
-            c.dimensions = dimensions;
-            c.position = position;
-        });
+        self.update_config(|c| c.dimensions = dimensions);
 
-        while let Ok(toast) = self.messages.try_recv() {
+        if let Some(messages) = self.messages.as_mut() {
+            while let Ok(toast) = messages.try_recv() {
                 self.toasts.add(toast);
             }
-        Panel::top("menubar")
-            .exact_size(22.0)
-            .show_inside(ui, |ui| {
+        }
+        TopBottomPanel::top("menubar")
+            .exact_height(22.0)
+            .show(ctx, |ui| {
                 MenuBar::new().ui(ui, |ui| {
-                    self.show_menu(ui);
+                    self.show_menu(ctx, ui);
                 });
             });
         if self.color_picker.is_some() {
@@ -704,71 +531,33 @@ impl AppWindow for GameWindow {
                 .title_bar(false)
                 .resizable(false)
                 .anchor(Align2::CENTER_CENTER, Vec2::ZERO)
-                .show(ui, |ui| {
+                .show(ctx, |ui| {
                     self.show_color_picker(ui);
                 });
         }
-        let frame = Frame::central_panel(ui.style()).fill(Color32::BLACK);
-        CentralPanel::default().frame(frame).show_inside(ui, |ui| {
+        let frame = Frame::central_panel(&ctx.style()).fill(Color32::BLACK);
+        CentralPanel::default().frame(frame).show(ctx, |ui| {
             if let Some(screen) = self.screen.as_mut() {
                 screen.update(self.config.display_mode, self.config.colors);
                 ui.add(screen);
             }
         });
-        self.toasts.show(ui);
-        for window in std::mem::take(&mut self.queued_children) {
-            self.do_open(window);
-        }
-        self.children.retain(|id, child| {
-            if child
-                .close_requested
-                .load(std::sync::atomic::Ordering::Relaxed)
-            {
-                return false;
-            }
-            let app = child.app.clone();
-            let viewport_builder = child.updates.take().unwrap_or_default();
-            let close_requested = child.close_requested.clone();
-            if let (Some(outer), Some(inner)) = ui.input_for(*id, |inp| {
-                let viewport = inp.viewport();
-                (viewport.outer_rect, viewport.inner_rect)
-            }) {
-                self.child_states.insert(
-                    *id,
-                    ChildState {
-                        position: outer.min,
-                        size: inner.size(),
-                    },
-                );
-            }
-            ui.show_viewport_deferred(*id, viewport_builder, move |ui, _| {
-                app.lock().unwrap().show(ui);
-                if ui.input(|s| s.viewport().close_requested()) {
-                    close_requested.store(true, std::sync::atomic::Ordering::Relaxed);
-                }
-            });
-            true
-        });
-        self.child_states.save(ui);
-        ui.request_repaint_after(Duration::from_millis(10));
+        self.toasts.show(ctx);
     }
 
-    fn on_init(&mut self, args: InitArgs) {
-        if self.screen.is_none() {
-            let (screen, sink) = GameScreen::init(args.render_state);
+    fn on_init(&mut self, _ctx: &Context, render_state: &egui_wgpu::RenderState) {
+        let (screen, sink) = GameScreen::init(render_state);
+        let (message_sink, message_source) = mpsc::channel();
         self.client.send_command(EmulatorCommand::ConnectToSim(
             self.sim_id,
             sink,
-                self.message_sink.clone(),
+            message_sink,
         ));
         self.screen = Some(screen);
-        }
-        self.file_picker.set_window(args.window);
-    }
+        self.messages = Some(message_source);
     }
 
-impl Drop for GameWindow {
-    fn drop(&mut self) {
+    fn on_destroy(&mut self) {
         if self.sim_id == SimId::Player2 {
             self.client.send_command(EmulatorCommand::StopSecondSim);
         }
@@ -782,84 +571,9 @@ struct ColorPickerState {
     unpause_on_close: bool,
 }
 
-struct ChildWindowWrapper {
-    app: Arc<Mutex<AppWrapper>>,
-    title: String,
-    sim_id: Option<SimId>,
-    updates: Option<ViewportBuilder>,
-    close_requested: Arc<AtomicBool>,
-}
-enum AppWrapper {
-    Game(Box<GameWindow>),
-    Dyn(Box<dyn AppWindow + Send + 'static>),
-}
-impl AppWrapper {
-    fn of_game(game: GameWindow) -> Self {
-        Self::Game(Box::new(game))
-    }
-    fn of_dyn<T: AppWindow + Send + 'static>(inner: T) -> Self {
-        Self::Dyn(Box::new(inner))
-    }
-}
-impl Deref for AppWrapper {
-    type Target = dyn AppWindow + Send + 'static;
-    fn deref(&self) -> &Self::Target {
-        match self {
-            Self::Dyn(inner) => inner.as_ref(),
-            Self::Game(inner) => inner.as_ref(),
-        }
-    }
-}
-impl DerefMut for AppWrapper {
-    fn deref_mut(&mut self) -> &mut Self::Target {
-        match self {
-            Self::Dyn(inner) => inner.as_mut(),
-            Self::Game(inner) => inner.as_mut(),
-        }
-    }
-}
-
-#[derive(Debug)]
-pub enum ChildWindow {
-    About,
-    CharacterData,
-    BgMap,
-    Objects,
-    Worlds,
-    FrameBuffers,
-    Registers,
-    Terminal,
-    Profiler { launch: bool },
-    Debugger { port: Option<u16> },
-    Input,
-    Hotkeys,
-    Player2,
-}
-impl ChildWindow {
-    fn viewport_id(&self, sim_id: SimId) -> ViewportId {
-        ViewportId::from_hash_of(format!("{sim_id:?}{}", self.name()))
-    }
-    fn name(&self) -> &'static str {
-        match self {
-            Self::About => "About",
-            Self::CharacterData => "CharacterData",
-            Self::BgMap => "BgMap",
-            Self::Objects => "Objects",
-            Self::Worlds => "Worlds",
-            Self::FrameBuffers => "FrameBuffers",
-            Self::Registers => "Registers",
-            Self::Terminal => "Terminal",
-            Self::Profiler { .. } => "Profiler",
-            Self::Debugger { .. } => "Debugger",
-            Self::Input => "Input",
-            Self::Hotkeys => "Hotkeys",
-            Self::Player2 => "Player2",
-        }
-    }
-}
-
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
-struct ChildState {
-    position: Pos2,
-    size: Vec2,
+#[derive(Serialize, Deserialize, Clone, PartialEq, Eq)]
+struct GameConfig {
+    display_mode: DisplayMode,
+    colors: [Color32; 2],
+    dimensions: Vec2,
 }

src/window/game_screen.rs

@@ -14,7 +14,7 @@ pub struct GameScreen {
 }
 
 impl GameScreen {
-    pub fn init_pipeline(render_state: &egui_wgpu::RenderState) {
+    fn init_pipeline(render_state: &egui_wgpu::RenderState) {
         let device = &render_state.device;
 
         let bind_group_layout = device.create_bind_group_layout(&wgpu::BindGroupLayoutDescriptor {
@@ -53,8 +53,8 @@ impl GameScreen {
         let render_pipeline_layout =
             device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
                 label: Some("render pipeline layout"),
-                bind_group_layouts: &[Some(&bind_group_layout)],
-                immediate_size: 0,
+                bind_group_layouts: &[&bind_group_layout],
+                push_constant_ranges: &[],
             });
 
         let create_render_pipeline = |entry_point: &str| {
@@ -92,7 +92,7 @@ impl GameScreen {
                     mask: !0,
                     alpha_to_coverage_enabled: false,
                 },
-                multiview_mask: None,
+                multiview: None,
                 cache: None,
             })
         };
@@ -117,6 +117,8 @@ impl GameScreen {
     }
 
     pub fn init(render_state: &egui_wgpu::RenderState) -> (Self, TextureSink) {
+        Self::init_pipeline(render_state);
+
         let device = &render_state.device;
         let queue = &render_state.queue;
 

src/window/gdb.rs

@@ -1,4 +1,4 @@
-use egui::{Button, CentralPanel, TextEdit, ViewportBuilder};
+use egui::{Button, CentralPanel, TextEdit, ViewportBuilder, ViewportId};
 use winit::event_loop::EventLoopProxy;
 
 use crate::{
@@ -42,20 +42,24 @@ impl GdbServerWindow {
 }
 
 impl AppWindow for GdbServerWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("Debugger-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("GDB Server")
+            .with_title(format!("GDB Server ({})", self.sim_id))
             .with_inner_size((300.0, 200.0))
     }
 
-    fn show(&mut self, ui: &mut egui::Ui) {
+    fn show(&mut self, ctx: &egui::Context) {
         let port_num: Option<u16> = self.port_str.parse().ok();
         let status = self.server.status();
-        CentralPanel::default().show_inside(ui, |ui| {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal(|ui| {
                 if port_num.is_none() {
                     let style = ui.style_mut();

src/window/hotkeys.rs

@@ -1,5 +1,6 @@
 use egui::{
-    Button, CentralPanel, Event, KeyboardShortcut, Label, Layout, Slider, Ui, ViewportBuilder,
+    Button, CentralPanel, Context, Event, KeyboardShortcut, Label, Layout, Slider, Ui,
+    ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, TableBuilder};
 
@@ -124,14 +125,18 @@ impl HotkeysWindow {
 }
 
 impl AppWindow for HotkeysWindow {
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of("shortcuts")
+    }
+
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
             .with_title("Keyboard Shortcuts")
             .with_inner_size((400.0, 400.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal(|ui| {
                 if ui.button("Use defaults").clicked() {
                     self.shortcuts.reset();

src/window/input.rs

@@ -1,4 +1,6 @@
-use egui::{Button, CentralPanel, Label, Layout, Panel, Ui, ViewportBuilder};
+use egui::{
+    Button, CentralPanel, Context, Label, Layout, TopBottomPanel, Ui, ViewportBuilder, ViewportId,
+};
 use egui_extras::{Column, TableBuilder};
 use gilrs::{EventType, GamepadId};
 use std::sync::RwLock;
@@ -160,14 +162,18 @@ impl InputWindow {
 }
 
 impl AppWindow for InputWindow {
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of("input")
+    }
+
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
             .with_title("Bind Inputs")
             .with_inner_size((600.0, 400.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        Panel::top("options").show_inside(ui, |ui| {
+    fn show(&mut self, ctx: &Context) {
+        TopBottomPanel::top("options").show(ctx, |ui| {
             ui.horizontal(|ui| {
                 let old_active_tab = self.active_tab;
                 ui.selectable_value(&mut self.active_tab, InputTab::Player1, "Player 1");
@@ -182,7 +188,7 @@ impl AppWindow for InputWindow {
                 }
             });
         });
-        CentralPanel::default().show_inside(ui, |ui| {
+        CentralPanel::default().show(ctx, |ui| {
             match self.active_tab {
                 InputTab::Player1 => self.show_key_bindings(ui, SimId::Player1),
                 InputTab::Player2 => self.show_key_bindings(ui, SimId::Player2),

src/window/profile.rs

@@ -1,14 +1,13 @@
 use std::{fs, time::Duration};
 
 use anyhow::Result;
-use egui::{Button, CentralPanel, Checkbox, Label, ViewportBuilder};
+use egui::{Button, CentralPanel, Checkbox, Label, ViewportBuilder, ViewportId};
 use egui_notify::{Anchor, Toast, Toasts};
 
 use crate::{
     emulator::{EmulatorClient, EmulatorCommand, EmulatorState, SimId},
-    filepicker::FilePicker,
     profiler::{Profiler, ProfilerStatus},
-    window::{AppWindow, InitArgs},
+    window::AppWindow,
 };
 
 pub struct ProfileWindow {
@@ -16,7 +15,6 @@ pub struct ProfileWindow {
     client: EmulatorClient,
     profiler: Profiler,
     toasts: Toasts,
-    file_picker: FilePicker,
 }
 
 impl ProfileWindow {
@@ -29,7 +27,6 @@ impl ProfileWindow {
                 .with_anchor(Anchor::BottomLeft)
                 .with_margin((10.0, 10.0).into())
                 .reverse(true),
-            file_picker: FilePicker::new(),
         }
     }
 
@@ -62,15 +59,12 @@ impl ProfileWindow {
 
     fn try_finish_recording(&mut self) -> Result<Option<String>> {
         let bytes_receiver = self.profiler.finish_recording();
-        let file = self
-            .file_picker
-            .new_dialog()
+        let file = rfd::FileDialog::new()
             .add_filter("Profiler files", &["json"])
             .set_file_name("profile.json")
             .save_file();
         if let Some(path) = file {
             let bytes = pollster::block_on(bytes_receiver)?;
-            let _ = fs::remove_file(&path);
             fs::write(&path, bytes)?;
             Ok(Some(path.display().to_string()))
         } else {
@@ -81,20 +75,24 @@ impl ProfileWindow {
 }
 
 impl AppWindow for ProfileWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("Profile-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Profiler")
+            .with_title(format!("Profiler ({})", self.sim_id))
             .with_inner_size((300.0, 200.0))
     }
 
-    fn show(&mut self, ui: &mut egui::Ui) {
+    fn show(&mut self, ctx: &egui::Context) {
         let status = self.profiler.status();
         let recording = matches!(status, ProfilerStatus::Recording);
-        CentralPanel::default().show_inside(ui, |ui| {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_wrapped(|ui| {
                 ui.spacing_mut().item_spacing.x = 0.0;
                 ui.add(
@@ -159,10 +157,6 @@ impl AppWindow for ProfileWindow {
                 _ => {}
             }
         });
-        self.toasts.show(ui);
-    }
-
-    fn on_init(&mut self, args: InitArgs) {
-        self.file_picker.set_window(args.window);
+        self.toasts.show(ctx);
     }
 }

src/window/terminal.rs

@@ -1,6 +1,9 @@
 use std::{collections::VecDeque, sync::mpsc};
 
-use egui::{Align, CentralPanel, FontFamily, Label, RichText, ScrollArea, Ui, ViewportBuilder};
+use egui::{
+    Align, CentralPanel, Context, FontFamily, Label, RichText, ScrollArea, ViewportBuilder,
+    ViewportId,
+};
 
 use crate::emulator::{EmulatorClient, EmulatorCommand, SimId};
 
@@ -29,17 +32,21 @@ impl TerminalWindow {
 }
 
 impl AppWindow for TerminalWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("terminal-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Terminal")
+            .with_title(format!("Terminal ({})", self.sim_id))
             .with_inner_size((640.0, 480.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
+    fn show(&mut self, ctx: &Context) {
         if let Ok(text) = self.receiver.try_recv() {
             let mut rest = text.as_str();
             while let Some(index) = rest.find('\n') {
@@ -54,7 +61,7 @@ impl AppWindow for TerminalWindow {
             }
             self.lines.back_mut().unwrap().push_str(rest);
         }
-        CentralPanel::default().show_inside(ui, |ui| {
+        CentralPanel::default().show(ctx, |ui| {
             ScrollArea::vertical()
                 .stick_to_bottom(true)
                 .auto_shrink([false, false])

src/window/utils.rs

@@ -1,6 +1,6 @@
 use std::{
     fmt::{Display, UpperHex},
-    ops::{AddAssign, Bound, Deref, DerefMut, MulAssign, RangeBounds},
+    ops::{Bound, RangeBounds},
     str::FromStr,
 };
 
@@ -8,9 +8,9 @@ use atoi::FromRadix16;
 use egui::{
     Align, Color32, CornerRadius, CursorIcon, Event, Frame, Key, Layout, Margin, Rect, Response,
     RichText, Sense, Shape, Stroke, StrokeKind, TextEdit, Ui, UiBuilder, Vec2, Widget, WidgetText,
-    ecolor::HexColor, util::id_type_map::SerializableAny,
+    ecolor::HexColor,
 };
-use num_traits::{CheckedAdd, CheckedSub, One, Zero};
+use num_traits::{CheckedAdd, CheckedSub, One};
 
 pub trait UiExt {
     fn section(&mut self, title: impl Into<String>, add_contents: impl FnOnce(&mut Ui));
@@ -105,16 +105,14 @@ enum Direction {
 
 pub trait Number:
     Copy
-    + Zero
     + One
-    + AddAssign
-    + MulAssign
     + CheckedAdd
     + CheckedSub
     + Eq
     + Ord
     + Display
     + FromStr
+    + FromRadix16
     + UpperHex
     + Send
     + Sync
@@ -123,16 +121,14 @@ pub trait Number:
 }
 impl<
     T: Copy
-        + Zero
         + One
-        + AddAssign
-        + MulAssign
         + CheckedAdd
         + CheckedSub
         + Eq
         + Ord
         + Display
         + FromStr
+        + FromRadix16
         + UpperHex
         + Send
         + Sync
@@ -213,8 +209,8 @@ impl<T: Number> Widget for NumberEdit<'_, T> {
         let from_string = |val: &str| {
             if self.hex {
                 let bytes = val.as_bytes();
-                let (result, consumed) = atoi::Integer::<T>::from_radix_16(bytes);
-                (consumed == bytes.len()).then_some(result.0)
+                let (result, consumed) = T::from_radix_16(bytes);
+                (consumed == bytes.len()).then_some(result)
             } else {
                 val.parse::<T>().ok()
             }
@@ -413,51 +409,3 @@ impl ResponseExt for Response {
         self.clicked() || self.dragged()
     }
 }
-
-pub struct UiData<T> {
-    current: T,
-    prev: T,
-    loaded: bool,
-}
-
-impl<T> UiData<T>
-where
-    T: Default + PartialEq + SerializableAny,
-{
-    pub fn new() -> Self {
-        Self {
-            current: T::default(),
-            prev: T::default(),
-            loaded: false,
-        }
-    }
-
-    pub fn load(&mut self, ui: &Ui) {
-        if !self.loaded {
-            self.current = ui
-                .data_mut(|d| d.get_persisted(ui.id()))
-                .unwrap_or_default();
-            self.loaded = true;
-        }
-    }
-
-    pub fn save(&mut self, ui: &Ui) {
-        if self.current != self.prev {
-            ui.data_mut(|d| d.insert_persisted(ui.id(), self.current.clone()));
-            self.prev = self.current.clone();
-        }
-    }
-}
-
-impl<T> Deref for UiData<T> {
-    type Target = T;
-    fn deref(&self) -> &Self::Target {
-        &self.current
-    }
-}
-
-impl<T> DerefMut for UiData<T> {
-    fn deref_mut(&mut self) -> &mut Self::Target {
-        &mut self.current
-    }
-}

src/window/vip/bgmap.rs

@@ -1,68 +1,51 @@
 use std::sync::Arc;
 
 use egui::{
-    Align, CentralPanel, Checkbox, Color32, ComboBox, Image, ScrollArea, Slider, TextEdit,
-    TextureOptions, Ui, ViewportBuilder,
+    Align, CentralPanel, Checkbox, Color32, ComboBox, Context, Image, ScrollArea, Slider, TextEdit,
+    TextureOptions, Ui, ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
-use serde::{Deserialize, Serialize};
 
 use crate::{
     emulator::SimId,
-    images::{ImageBuffer, ImageParams, ImageRenderer, ImageTextureLoader},
+    images::{ImageBuffer, ImageParams, ImageProcessor, ImageRenderer, ImageTextureLoader},
     memory::{MemoryClient, MemoryView},
     window::{
         AppWindow,
-        utils::{NumberEdit, UiData, UiExt},
+        utils::{NumberEdit, UiExt},
     },
 };
 
 use super::utils::{self, CellData, CharacterGrid};
 
-#[derive(Clone, PartialEq, Serialize, Deserialize)]
-struct State {
+pub struct BgMapWindow {
+    sim_id: SimId,
+    loader: Arc<ImageTextureLoader>,
+    memory: Arc<MemoryClient>,
+    bgmaps: MemoryView,
     cell_index: usize,
     generic_palette: bool,
+    params: ImageParams<BgMapParams>,
     scale: f32,
     show_grid: bool,
 }
-impl Default for State {
-    fn default() -> Self {
-        Self {
-            cell_index: 0,
-            generic_palette: false,
-            scale: 1.0,
-            show_grid: false,
-        }
-    }
-}
-
-pub struct BgMapWindow {
-    sim_id: SimId,
-    memory: Arc<MemoryClient>,
-    bgmaps: MemoryView,
-    params: ImageParams<BgMapParams>,
-    state: UiData<State>,
-}
 
 impl BgMapWindow {
-    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &ImageTextureLoader) -> Self {
-        let state: UiData<State> = UiData::new();
+    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &mut ImageProcessor) -> Self {
         let renderer = BgMapRenderer::new(sim_id, memory);
-        let params = images.add(
-            sim_id,
-            renderer,
-            BgMapParams {
-                cell_index: state.cell_index,
-                generic_palette: state.generic_palette,
-            },
-        );
+        let ([cell, bgmap], params) = images.add(renderer, BgMapParams::default());
+        let loader =
+            ImageTextureLoader::new([("vip://cell".into(), cell), ("vip://bgmap".into(), bgmap)]);
         Self {
             sim_id,
+            loader: Arc::new(loader),
             memory: memory.clone(),
             bgmaps: memory.watch(sim_id, 0x00020000, 0x20000),
+            cell_index: params.cell_index,
+            generic_palette: params.generic_palette,
             params,
-            state,
+            scale: 1.0,
+            show_grid: false,
         }
     }
 
@@ -78,11 +61,10 @@ impl BgMapWindow {
                             ui.label("Map");
                         });
                         row.col(|ui| {
-                            let mut bgmap_index = self.state.cell_index / 4096;
+                            let mut bgmap_index = self.cell_index / 4096;
                             ui.add(NumberEdit::new(&mut bgmap_index).range(0..16));
-                            if bgmap_index != self.state.cell_index / 4096 {
-                                self.state.cell_index =
-                                    (bgmap_index * 4096) + (self.state.cell_index % 4096);
+                            if bgmap_index != self.cell_index / 4096 {
+                                self.cell_index = (bgmap_index * 4096) + (self.cell_index % 4096);
                             }
                         });
                     });
@@ -91,7 +73,7 @@ impl BgMapWindow {
                             ui.label("Cell");
                         });
                         row.col(|ui| {
-                            ui.add(NumberEdit::new(&mut self.state.cell_index).range(0..16 * 4096));
+                            ui.add(NumberEdit::new(&mut self.cell_index).range(0..16 * 4096));
                         });
                     });
                     body.row(row_height, |mut row| {
@@ -99,7 +81,7 @@ impl BgMapWindow {
                             ui.label("Address");
                         });
                         row.col(|ui| {
-                            let address = 0x00020000 + (self.state.cell_index * 2);
+                            let address = 0x00020000 + (self.cell_index * 2);
                             let mut address_str = format!("{address:08x}");
                             ui.add_enabled(
                                 false,
@@ -108,12 +90,12 @@ impl BgMapWindow {
                         });
                     });
                 });
-            let image = Image::new(self.image_url("bgmap-cell"))
+            let image = Image::new("vip://cell")
                 .maintain_aspect_ratio(true)
                 .texture_options(TextureOptions::NEAREST);
             ui.add(image);
             ui.section("Cell", |ui| {
-                let mut data = self.bgmaps.borrow().read::<u16>(self.state.cell_index);
+                let mut data = self.bgmaps.borrow().read::<u16>(self.cell_index);
                 let mut cell = CellData::parse(data);
                 TableBuilder::new(ui)
                     .column(Column::remainder())
@@ -156,7 +138,7 @@ impl BgMapWindow {
                         });
                     });
                 if cell.update(&mut data) {
-                    let address = 0x00020000 + (self.state.cell_index * 2);
+                    let address = 0x00020000 + (self.cell_index * 2);
                     self.memory.write(self.sim_id, address as u32, &data);
                 }
             });
@@ -164,46 +146,53 @@ impl BgMapWindow {
                 ui.horizontal(|ui| {
                     ui.label("Scale");
                     ui.spacing_mut().slider_width = ui.available_width();
-                    let slider = Slider::new(&mut self.state.scale, 1.0..=10.0)
+                    let slider = Slider::new(&mut self.scale, 1.0..=10.0)
                         .step_by(1.0)
                         .show_value(false);
                     ui.add(slider);
                 });
-                ui.checkbox(&mut self.state.show_grid, "Show grid");
-                ui.checkbox(&mut self.state.generic_palette, "Generic palette");
+                ui.checkbox(&mut self.show_grid, "Show grid");
+                ui.checkbox(&mut self.generic_palette, "Generic palette");
             });
         });
         self.params.write(BgMapParams {
-            cell_index: self.state.cell_index,
-            generic_palette: self.state.generic_palette,
+            cell_index: self.cell_index,
+            generic_palette: self.generic_palette,
         });
     }
 
     fn show_bgmap(&mut self, ui: &mut Ui) {
-        let grid = CharacterGrid::new(self.image_url("bgmap"))
-            .with_scale(self.state.scale)
-            .with_grid(self.state.show_grid)
-            .with_selected(self.state.cell_index % 4096);
+        let grid = CharacterGrid::new("vip://bgmap")
+            .with_scale(self.scale)
+            .with_grid(self.show_grid)
+            .with_selected(self.cell_index % 4096);
         if let Some(selected) = grid.show(ui) {
-            self.state.cell_index = (self.state.cell_index / 4096 * 4096) + selected;
+            self.cell_index = (self.cell_index / 4096 * 4096) + selected;
         }
     }
 }
 
 impl AppWindow for BgMapWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("bgmap-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("BG Map Data")
+            .with_title(format!("BG Map Data ({})", self.sim_id))
             .with_inner_size((640.0, 480.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        self.state.load(ui);
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn on_init(&mut self, ctx: &Context, _render_state: &egui_wgpu::RenderState) {
+        ctx.add_texture_loader(self.loader.clone());
+    }
+
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_top(|ui| {
                 StripBuilder::new(ui)
                     .size(Size::relative(0.3).at_most(200.0))
@@ -218,7 +207,6 @@ impl AppWindow for BgMapWindow {
                     })
             });
         });
-        self.state.save(ui);
     }
 }
 
@@ -312,10 +300,6 @@ impl BgMapRenderer {
 impl ImageRenderer<2> for BgMapRenderer {
     type Params = BgMapParams;
 
-    fn names(&self) -> [&str; 2] {
-        ["bgmap-cell", "bgmap"]
-    }
-
     fn sizes(&self) -> [[usize; 2]; 2] {
         [[8, 8], [8 * 64, 8 * 64]]
     }

src/window/vip/chardata.rs

@@ -1,19 +1,19 @@
-use std::fmt::Display;
+use std::{fmt::Display, sync::Arc};
 
 use egui::{
-    Align, CentralPanel, Color32, ComboBox, Image, ScrollArea, Slider, TextEdit, TextureOptions,
-    Ui, Vec2, ViewportBuilder,
+    Align, CentralPanel, Color32, ComboBox, Context, Image, ScrollArea, Slider, TextEdit,
+    TextureOptions, Ui, Vec2, ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
 use serde::{Deserialize, Serialize};
 
 use crate::{
     emulator::SimId,
-    images::{ImageBuffer, ImageParams, ImageRenderer, ImageTextureLoader},
+    images::{ImageBuffer, ImageParams, ImageProcessor, ImageRenderer, ImageTextureLoader},
     memory::{MemoryClient, MemoryView},
     window::{
         AppWindow,
-        utils::{NumberEdit, UiData, UiExt as _},
+        utils::{NumberEdit, UiExt as _},
     },
 };
 
@@ -79,50 +79,36 @@ impl Display for Palette {
     }
 }
 
-#[derive(Clone, PartialEq, Serialize, Deserialize)]
-struct State {
+pub struct CharacterDataWindow {
+    sim_id: SimId,
+    loader: Arc<ImageTextureLoader>,
+    brightness: MemoryView,
+    palettes: MemoryView,
     palette: Palette,
     index: usize,
+    params: ImageParams<CharDataParams>,
     scale: f32,
     show_grid: bool,
 }
-impl Default for State {
-    fn default() -> Self {
-        Self {
-            palette: Palette::default(),
-            index: 0,
-            scale: 4.0,
-            show_grid: true,
-        }
-    }
-}
-
-pub struct CharacterDataWindow {
-    sim_id: SimId,
-    brightness: MemoryView,
-    palettes: MemoryView,
-    params: ImageParams<CharDataParams>,
-    state: UiData<State>,
-}
 
 impl CharacterDataWindow {
-    pub fn new(sim_id: SimId, memory: &MemoryClient, images: &ImageTextureLoader) -> Self {
-        let state: UiData<State> = UiData::new();
+    pub fn new(sim_id: SimId, memory: &MemoryClient, images: &mut ImageProcessor) -> Self {
         let renderer = CharDataRenderer::new(sim_id, memory);
-        let params = images.add(
-            sim_id,
-            renderer,
-            CharDataParams {
-                palette: state.palette,
-                index: state.index,
-            },
-        );
+        let ([char, chardata], params) = images.add(renderer, CharDataParams::default());
+        let loader = ImageTextureLoader::new([
+            ("vip://char".into(), char),
+            ("vip://chardata".into(), chardata),
+        ]);
         Self {
             sim_id,
+            loader: Arc::new(loader),
             brightness: memory.watch(sim_id, 0x0005f824, 8),
             palettes: memory.watch(sim_id, 0x0005f860, 16),
+            palette: params.palette,
+            index: params.index,
             params,
-            state,
+            scale: 4.0,
+            show_grid: true,
         }
     }
 
@@ -138,7 +124,7 @@ impl CharacterDataWindow {
                             ui.label("Index");
                         });
                         row.col(|ui| {
-                            ui.add(NumberEdit::new(&mut self.state.index).range(0..2048));
+                            ui.add(NumberEdit::new(&mut self.index).range(0..2048));
                         });
                     });
                     body.row(row_height, |mut row| {
@@ -146,11 +132,11 @@ impl CharacterDataWindow {
                             ui.label("Address");
                         });
                         row.col(|ui| {
-                            let address = match self.state.index {
-                                0x000..0x200 => 0x00060000 + self.state.index * 16,
-                                0x200..0x400 => 0x000e0000 + (self.state.index - 0x200) * 16,
-                                0x400..0x600 => 0x00160000 + (self.state.index - 0x400) * 16,
-                                0x600..0x800 => 0x001e0000 + (self.state.index - 0x600) * 16,
+                            let address = match self.index {
+                                0x000..0x200 => 0x00060000 + self.index * 16,
+                                0x200..0x400 => 0x000e0000 + (self.index - 0x200) * 16,
+                                0x400..0x600 => 0x00160000 + (self.index - 0x400) * 16,
+                                0x600..0x800 => 0x001e0000 + (self.index - 0x600) * 16,
                                 _ => unreachable!("can't happen"),
                             };
                             let mut address_str = format!("{address:08x}");
@@ -165,7 +151,7 @@ impl CharacterDataWindow {
                             ui.label("Mirror");
                         });
                         row.col(|ui| {
-                            let mirror = 0x00078000 + (self.state.index * 16);
+                            let mirror = 0x00078000 + (self.index * 16);
                             let mut mirror_str = format!("{mirror:08x}");
                             ui.add_enabled(
                                 false,
@@ -174,7 +160,7 @@ impl CharacterDataWindow {
                         });
                     });
                 });
-            let image = Image::new(self.image_url("chardata-char"))
+            let image = Image::new("vip://char")
                 .maintain_aspect_ratio(true)
                 .texture_options(TextureOptions::NEAREST);
             ui.add(image);
@@ -182,12 +168,12 @@ impl CharacterDataWindow {
                 ui.horizontal(|ui| {
                     ui.label("Palette");
                     ComboBox::from_id_salt("palette")
-                        .selected_text(self.state.palette.to_string())
+                        .selected_text(self.palette.to_string())
                         .width(ui.available_width())
                         .show_ui(ui, |ui| {
                             for palette in Palette::values() {
                                 ui.selectable_value(
-                                    &mut self.state.palette,
+                                    &mut self.palette,
                                     palette,
                                     palette.to_string(),
                                 );
@@ -214,23 +200,23 @@ impl CharacterDataWindow {
                 ui.horizontal(|ui| {
                     ui.label("Scale");
                     ui.spacing_mut().slider_width = ui.available_width();
-                    let slider = Slider::new(&mut self.state.scale, 1.0..=10.0)
+                    let slider = Slider::new(&mut self.scale, 1.0..=10.0)
                         .step_by(1.0)
                         .show_value(false);
                     ui.add(slider);
                 });
-                ui.checkbox(&mut self.state.show_grid, "Show grid");
+                ui.checkbox(&mut self.show_grid, "Show grid");
             });
         });
 
         self.params.write(CharDataParams {
-            palette: self.state.palette,
-            index: self.state.index,
+            palette: self.palette,
+            index: self.index,
         });
     }
 
     fn load_palette_colors(&self) -> [Color32; 4] {
-        let Some(offset) = self.state.palette.offset() else {
+        let Some(offset) = self.palette.offset() else {
             return utils::generic_palette(Color32::RED);
         };
         let palette = self.palettes.borrow().read(offset);
@@ -240,30 +226,37 @@ impl CharacterDataWindow {
     }
 
     fn show_chardata(&mut self, ui: &mut Ui) {
-        let grid = CharacterGrid::new(self.image_url("chardata"))
-            .with_scale(self.state.scale)
-            .with_grid(self.state.show_grid)
-            .with_selected(self.state.index);
+        let grid = CharacterGrid::new("vip://chardata")
+            .with_scale(self.scale)
+            .with_grid(self.show_grid)
+            .with_selected(self.index);
         if let Some(selected) = grid.show(ui) {
-            self.state.index = selected;
+            self.index = selected;
         }
     }
 }
 
 impl AppWindow for CharacterDataWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("chardata-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Character Data")
+            .with_title(format!("Character Data ({})", self.sim_id))
             .with_inner_size((640.0, 480.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        self.state.load(ui);
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn on_init(&mut self, ctx: &Context, _render_state: &egui_wgpu::RenderState) {
+        ctx.add_texture_loader(self.loader.clone());
+    }
+
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_top(|ui| {
                 StripBuilder::new(ui)
                     .size(Size::relative(0.3).at_most(200.0))
@@ -278,11 +271,16 @@ impl AppWindow for CharacterDataWindow {
                     });
             });
         });
-        self.state.save(ui);
     }
 }
 
-#[derive(Clone, PartialEq, Eq)]
+#[derive(Serialize, Deserialize, Clone, PartialEq, Eq, Hash)]
+enum CharDataResource {
+    Character { palette: Palette, index: usize },
+    CharacterData { palette: Palette },
+}
+
+#[derive(Clone, Default, PartialEq, Eq)]
 struct CharDataParams {
     palette: Palette,
     index: usize,
@@ -297,10 +295,6 @@ struct CharDataRenderer {
 impl ImageRenderer<2> for CharDataRenderer {
     type Params = CharDataParams;
 
-    fn names(&self) -> [&str; 2] {
-        ["chardata-char", "chardata"]
-    }
-
     fn sizes(&self) -> [[usize; 2]; 2] {
         [[8, 8], [16 * 8, 128 * 8]]
     }

src/window/vip/framebuffer.rs

@@ -1,68 +1,56 @@
+use std::sync::Arc;
+
 use egui::{
-    Align, CentralPanel, Color32, Image, ScrollArea, Slider, TextEdit, TextureOptions, Ui,
-    ViewportBuilder,
+    Align, CentralPanel, Color32, Context, Image, ScrollArea, Slider, TextEdit, TextureOptions, Ui,
+    ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
-use serde::{Deserialize, Serialize};
 
 use crate::{
     emulator::SimId,
-    images::{ImageBuffer, ImageParams, ImageRenderer, ImageTextureLoader},
+    images::{ImageBuffer, ImageParams, ImageProcessor, ImageRenderer, ImageTextureLoader},
     memory::{MemoryClient, MemoryView},
     window::{
         AppWindow,
-        utils::{NumberEdit, UiData, UiExt as _},
+        utils::{NumberEdit, UiExt as _},
     },
 };
 
 use super::utils;
 
-#[derive(Clone, PartialEq, Serialize, Deserialize)]
-struct State {
+pub struct FrameBufferWindow {
+    sim_id: SimId,
+    loader: Arc<ImageTextureLoader>,
     index: usize,
     left: bool,
     right: bool,
     generic_palette: bool,
+    params: ImageParams<FrameBufferParams>,
     scale: f32,
 }
-impl Default for State {
-    fn default() -> Self {
-        Self {
+
+impl FrameBufferWindow {
+    pub fn new(sim_id: SimId, memory: &MemoryClient, images: &mut ImageProcessor) -> Self {
+        let initial_params = FrameBufferParams {
             index: 0,
             left: true,
             right: true,
             generic_palette: false,
-            scale: 2.0,
-        }
-    }
-}
-
-pub struct FrameBufferWindow {
-    sim_id: SimId,
-    params: ImageParams<FrameBufferParams>,
-    state: UiData<State>,
-}
-
-impl FrameBufferWindow {
-    pub fn new(sim_id: SimId, memory: &MemoryClient, images: &ImageTextureLoader) -> Self {
-        let state: UiData<State> = UiData::new();
-        let renderer = FrameBufferRenderer::new(sim_id, memory);
-        let params = images.add(
-            sim_id,
-            renderer,
-            FrameBufferParams {
-                index: state.index,
-                left: state.left,
-                right: state.right,
-                generic_palette: state.generic_palette,
             left_color: Color32::from_rgb(0xff, 0x00, 0x00),
             right_color: Color32::from_rgb(0x00, 0xc6, 0xf0),
-            },
-        );
+        };
+        let renderer = FrameBufferRenderer::new(sim_id, memory);
+        let ([buffer], params) = images.add(renderer, initial_params);
+        let loader = ImageTextureLoader::new([("vip://buffer".into(), buffer)]);
         Self {
             sim_id,
+            loader: Arc::new(loader),
+            index: params.index,
+            left: params.left,
+            right: params.right,
+            generic_palette: params.generic_palette,
             params,
-            state,
+            scale: 2.0,
         }
     }
 
@@ -78,7 +66,7 @@ impl FrameBufferWindow {
                             ui.label("Index");
                         });
                         row.col(|ui| {
-                            ui.add(NumberEdit::new(&mut self.state.index).range(0..2));
+                            ui.add(NumberEdit::new(&mut self.index).range(0..2));
                         });
                     });
                     body.row(row_height, |mut row| {
@@ -86,7 +74,7 @@ impl FrameBufferWindow {
                             ui.label("Left");
                         });
                         row.col(|ui| {
-                            let address = self.state.index * 0x00008000;
+                            let address = self.index * 0x00008000;
                             let mut address_str = format!("{address:08x}");
                             ui.add_enabled(
                                 false,
@@ -99,7 +87,7 @@ impl FrameBufferWindow {
                             ui.label("Right");
                         });
                         row.col(|ui| {
-                            let address = self.state.index * 0x00008000 + 0x00010000;
+                            let address = self.index * 0x00008000 + 0x00010000;
                             let mut address_str = format!("{address:08x}");
                             ui.add_enabled(
                                 false,
@@ -112,7 +100,7 @@ impl FrameBufferWindow {
                 ui.horizontal(|ui| {
                     ui.label("Scale");
                     ui.spacing_mut().slider_width = ui.available_width();
-                    let slider = Slider::new(&mut self.state.scale, 1.0..=10.0)
+                    let slider = Slider::new(&mut self.scale, 1.0..=10.0)
                         .step_by(1.0)
                         .show_value(false);
                     ui.add(slider);
@@ -122,48 +110,55 @@ impl FrameBufferWindow {
                     .body(|mut body| {
                         body.row(row_height, |mut row| {
                             row.col(|ui| {
-                                ui.checkbox(&mut self.state.left, "Left");
+                                ui.checkbox(&mut self.left, "Left");
                             });
                             row.col(|ui| {
-                                ui.checkbox(&mut self.state.right, "Right");
+                                ui.checkbox(&mut self.right, "Right");
                             });
                         });
                     });
-                ui.checkbox(&mut self.state.generic_palette, "Generic colors");
+                ui.checkbox(&mut self.generic_palette, "Generic colors");
             });
         });
 
         self.params.write(FrameBufferParams {
-            index: self.state.index,
-            left: self.state.left,
-            right: self.state.right,
-            generic_palette: self.state.generic_palette,
+            index: self.index,
+            left: self.left,
+            right: self.right,
+            generic_palette: self.generic_palette,
             ..*self.params
         });
     }
 
     fn show_buffers(&mut self, ui: &mut Ui) {
-        let image = Image::new(self.image_url("buffer"))
-            .fit_to_original_size(self.state.scale)
+        let image = Image::new("vip://buffer")
+            .fit_to_original_size(self.scale)
             .texture_options(TextureOptions::NEAREST);
         ui.add(image);
     }
 }
 
 impl AppWindow for FrameBufferWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("framebuffer-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Frame Buffers")
+            .with_title(format!("Frame Buffers ({})", self.sim_id))
             .with_inner_size((640.0, 480.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        self.state.load(ui);
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn on_init(&mut self, ctx: &Context, _render_state: &egui_wgpu::RenderState) {
+        ctx.add_texture_loader(self.loader.clone());
+    }
+
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_top(|ui| {
                 StripBuilder::new(ui)
                     .size(Size::relative(0.3).at_most(200.0))
@@ -178,7 +173,6 @@ impl AppWindow for FrameBufferWindow {
                     });
             });
         });
-        self.state.save(ui);
     }
 }
 
@@ -214,10 +208,6 @@ impl FrameBufferRenderer {
 impl ImageRenderer<1> for FrameBufferRenderer {
     type Params = FrameBufferParams;
 
-    fn names(&self) -> [&str; 1] {
-        ["buffer"]
-    }
-
     fn sizes(&self) -> [[usize; 2]; 1] {
         [[384, 224]]
     }

src/window/vip/object.rs

@@ -1,68 +1,55 @@
 use std::sync::Arc;
 
 use egui::{
-    Align, CentralPanel, Checkbox, Color32, ComboBox, Image, ScrollArea, Slider, TextEdit,
-    TextureOptions, Ui, ViewportBuilder,
+    Align, CentralPanel, Checkbox, Color32, ComboBox, Context, Image, ScrollArea, Slider, TextEdit,
+    TextureOptions, Ui, ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
-use serde::{Deserialize, Serialize};
 
 use crate::{
     emulator::SimId,
-    images::{ImageBuffer, ImageParams, ImageRenderer, ImageTextureLoader},
+    images::{ImageBuffer, ImageParams, ImageProcessor, ImageRenderer, ImageTextureLoader},
     memory::{MemoryClient, MemoryView},
     window::{
         AppWindow,
-        utils::{NumberEdit, UiData, UiExt as _},
+        utils::{NumberEdit, UiExt as _},
     },
 };
 
 use super::utils::{self, Object};
 
-#[derive(Clone, PartialEq, Serialize, Deserialize)]
-struct State {
-    index: usize,
-    generic_palette: bool,
-    scale: f32,
-}
-impl Default for State {
-    fn default() -> Self {
-        Self {
-            index: 0,
-            generic_palette: false,
-            scale: 1.0,
-        }
-    }
-}
-
 pub struct ObjectWindow {
     sim_id: SimId,
+    loader: Arc<ImageTextureLoader>,
     memory: Arc<MemoryClient>,
     objects: MemoryView,
+    index: usize,
+    generic_palette: bool,
     params: ImageParams<ObjectParams>,
-    state: UiData<State>,
+    scale: f32,
 }
 
 impl ObjectWindow {
-    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &ImageTextureLoader) -> Self {
-        let state: UiData<State> = UiData::new();
-        let renderer = ObjectRenderer::new(sim_id, memory);
-        let params = images.add(
-            sim_id,
-            renderer,
-            ObjectParams {
-                index: state.index,
-                generic_palette: state.generic_palette,
+    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &mut ImageProcessor) -> Self {
+        let initial_params = ObjectParams {
+            index: 0,
+            generic_palette: false,
             left_color: Color32::from_rgb(0xff, 0x00, 0x00),
             right_color: Color32::from_rgb(0x00, 0xc6, 0xf0),
-            },
-        );
+        };
+        let renderer = ObjectRenderer::new(sim_id, memory);
+        let ([zoom, full], params) = images.add(renderer, initial_params);
+        let loader =
+            ImageTextureLoader::new([("vip://zoom".into(), zoom), ("vip://full".into(), full)]);
         Self {
             sim_id,
+            loader: Arc::new(loader),
             memory: memory.clone(),
             objects: memory.watch(sim_id, 0x0003e000, 0x2000),
+            index: params.index,
+            generic_palette: params.generic_palette,
             params,
-            state,
+            scale: 1.0,
         }
     }
 
@@ -78,7 +65,7 @@ impl ObjectWindow {
                             ui.label("Index");
                         });
                         row.col(|ui| {
-                            ui.add(NumberEdit::new(&mut self.state.index).range(0..1024));
+                            ui.add(NumberEdit::new(&mut self.index).range(0..1024));
                         });
                     });
                     body.row(row_height, |mut row| {
@@ -86,7 +73,7 @@ impl ObjectWindow {
                             ui.label("Address");
                         });
                         row.col(|ui| {
-                            let address = 0x3e000 + self.state.index * 8;
+                            let address = 0x3e000 + self.index * 8;
                             let mut address_str = format!("{address:08x}");
                             ui.add_enabled(
                                 false,
@@ -95,12 +82,12 @@ impl ObjectWindow {
                         });
                     });
                 });
-            let image = Image::new(self.image_url("object-zoom"))
+            let image = Image::new("vip://zoom")
                 .maintain_aspect_ratio(true)
                 .texture_options(TextureOptions::NEAREST);
             ui.add(image);
             ui.section("Properties", |ui| {
-                let mut object = self.objects.borrow().read::<[u16; 4]>(self.state.index);
+                let mut object = self.objects.borrow().read::<[u16; 4]>(self.index);
                 let mut obj = Object::parse(object);
                 TableBuilder::new(ui)
                     .column(Column::remainder())
@@ -175,7 +162,7 @@ impl ObjectWindow {
                         });
                     });
                 if obj.update(&mut object) {
-                    let address = 0x3e000 + self.state.index * 8;
+                    let address = 0x3e000 + self.index * 8;
                     self.memory.write(self.sim_id, address as u32, &object);
                 }
             });
@@ -183,43 +170,50 @@ impl ObjectWindow {
                 ui.horizontal(|ui| {
                     ui.label("Scale");
                     ui.spacing_mut().slider_width = ui.available_width();
-                    let slider = Slider::new(&mut self.state.scale, 1.0..=10.0)
+                    let slider = Slider::new(&mut self.scale, 1.0..=10.0)
                         .step_by(1.0)
                         .show_value(false);
                     ui.add(slider);
                 });
-                ui.checkbox(&mut self.state.generic_palette, "Generic palette");
+                ui.checkbox(&mut self.generic_palette, "Generic palette");
             });
         });
         self.params.write(ObjectParams {
-            index: self.state.index,
-            generic_palette: self.state.generic_palette,
+            index: self.index,
+            generic_palette: self.generic_palette,
             ..*self.params
         });
     }
 
     fn show_object(&mut self, ui: &mut Ui) {
-        let image = Image::new(self.image_url("object-full"))
-            .fit_to_original_size(self.state.scale)
+        let image = Image::new("vip://full")
+            .fit_to_original_size(self.scale)
             .texture_options(TextureOptions::NEAREST);
         ui.add(image);
     }
 }
 
 impl AppWindow for ObjectWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> egui::ViewportId {
+        ViewportId::from_hash_of(format!("object-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Object Data")
+            .with_title(format!("Object Data ({})", self.sim_id))
             .with_inner_size((640.0, 500.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        self.state.load(ui);
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn on_init(&mut self, ctx: &Context, _render_state: &egui_wgpu::RenderState) {
+        ctx.add_texture_loader(self.loader.clone());
+    }
+
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_top(|ui| {
                 StripBuilder::new(ui)
                     .size(Size::relative(0.3).at_most(200.0))
@@ -234,7 +228,6 @@ impl AppWindow for ObjectWindow {
                     });
             });
         });
-        self.state.save(ui);
     }
 }
 
@@ -334,10 +327,6 @@ impl ObjectRenderer {
 impl ImageRenderer<2> for ObjectRenderer {
     type Params = ObjectParams;
 
-    fn names(&self) -> [&str; 2] {
-        ["object-zoom", "object-full"]
-    }
-
     fn sizes(&self) -> [[usize; 2]; 2] {
         [[8, 8], [384, 224]]
     }

src/window/vip/registers.rs

@@ -1,8 +1,8 @@
 use std::sync::Arc;
 
 use egui::{
-    Align, Button, CentralPanel, Checkbox, Color32, Direction, Label, Layout, ScrollArea, TextEdit,
-    Ui, ViewportBuilder,
+    Align, Button, CentralPanel, Checkbox, Color32, Context, Direction, Label, Layout, ScrollArea,
+    TextEdit, Ui, ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
 
@@ -630,18 +630,22 @@ fn read_address<T: MemoryValue>(registers: &MemoryRef, address: usize) -> T {
 }
 
 impl AppWindow for RegisterWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("registers-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Registers")
+            .with_title(format!("Registers ({})", self.sim_id))
             .with_inner_size((800.0, 480.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ScrollArea::vertical().show(ui, |ui| {
                 ui.horizontal_top(|ui| {
                     let width = ui.available_width();

src/window/vip/world.rs

@@ -1,8 +1,8 @@
 use std::{fmt::Display, sync::Arc};
 
 use egui::{
-    Align, CentralPanel, Checkbox, Color32, ComboBox, Image, ScrollArea, Slider, TextEdit,
-    TextureOptions, Ui, ViewportBuilder,
+    Align, CentralPanel, Checkbox, Color32, ComboBox, Context, Image, ScrollArea, Slider, TextEdit,
+    TextureOptions, Ui, ViewportBuilder, ViewportId,
 };
 use egui_extras::{Column, Size, StripBuilder, TableBuilder};
 use fixed::{
@@ -11,70 +11,56 @@ use fixed::{
 };
 use num_derive::{FromPrimitive, ToPrimitive};
 use num_traits::{FromPrimitive, ToPrimitive};
-use serde::{Deserialize, Serialize};
 
 use crate::{
     emulator::SimId,
-    images::{ImageBuffer, ImageParams, ImageRenderer, ImageTextureLoader},
+    images::{ImageBuffer, ImageParams, ImageProcessor, ImageRenderer, ImageTextureLoader},
     memory::{MemoryClient, MemoryRef, MemoryView},
     window::{
         AppWindow,
-        utils::{NumberEdit, UiData, UiExt as _},
+        utils::{NumberEdit, UiExt as _},
     },
 };
 
 use super::utils::{self, CellData, Object, shade};
 
-#[derive(Clone, PartialEq, Serialize, Deserialize)]
-struct State {
+pub struct WorldWindow {
+    sim_id: SimId,
+    loader: Arc<ImageTextureLoader>,
+    memory: Arc<MemoryClient>,
+    worlds: MemoryView,
+    bgmaps: MemoryView,
     index: usize,
     param_index: usize,
     generic_palette: bool,
     show_extents: bool,
-    scale: f32,
-}
-impl Default for State {
-    fn default() -> Self {
-        Self {
-            index: 31,
-            param_index: 0,
-            generic_palette: false,
-            show_extents: false,
-            scale: 1.0,
-        }
-    }
-}
-
-pub struct WorldWindow {
-    sim_id: SimId,
-    memory: Arc<MemoryClient>,
-    worlds: MemoryView,
-    bgmaps: MemoryView,
     params: ImageParams<WorldParams>,
-    state: UiData<State>,
+    scale: f32,
 }
 
 impl WorldWindow {
-    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &ImageTextureLoader) -> Self {
-        let state: UiData<State> = UiData::new();
-        let renderer = WorldRenderer::new(sim_id, memory);
-        let params = images.add(
-            sim_id,
-            renderer,
-            WorldParams {
-                index: state.index,
-                generic_palette: state.generic_palette,
+    pub fn new(sim_id: SimId, memory: &Arc<MemoryClient>, images: &mut ImageProcessor) -> Self {
+        let initial_params = WorldParams {
+            index: 31,
+            generic_palette: false,
             left_color: Color32::from_rgb(0xff, 0x00, 0x00),
             right_color: Color32::from_rgb(0x00, 0xc6, 0xf0),
-            },
-        );
+        };
+        let renderer = WorldRenderer::new(sim_id, memory);
+        let ([world], params) = images.add(renderer, initial_params);
+        let loader = ImageTextureLoader::new([("vip://world".into(), world)]);
         Self {
             sim_id,
+            loader: Arc::new(loader),
             memory: memory.clone(),
             worlds: memory.watch(sim_id, 0x0003d800, 0x400),
             bgmaps: memory.watch(sim_id, 0x00020000, 0x20000),
+            index: params.index,
+            param_index: 0,
+            generic_palette: params.generic_palette,
+            show_extents: false,
             params,
-            state,
+            scale: 1.0,
         }
     }
 
@@ -90,7 +76,7 @@ impl WorldWindow {
                             ui.label("Index");
                         });
                         row.col(|ui| {
-                            ui.add(NumberEdit::new(&mut self.state.index).range(0..32));
+                            ui.add(NumberEdit::new(&mut self.index).range(0..32));
                         });
                     });
                     body.row(row_height, |mut row| {
@@ -98,7 +84,7 @@ impl WorldWindow {
                             ui.label("Address");
                         });
                         row.col(|ui| {
-                            let address = 0x0003d800 + self.state.index * 32;
+                            let address = 0x0003d800 + self.index * 32;
                             let mut address_str = format!("{address:08x}");
                             ui.add_enabled(
                                 false,
@@ -109,7 +95,7 @@ impl WorldWindow {
                 });
             let mut data = {
                 let worlds = self.worlds.borrow();
-                worlds.read(self.state.index)
+                worlds.read(self.index)
             };
             let mut world = World::parse(&data);
             ui.section("Properties", |ui| {
@@ -289,7 +275,7 @@ impl WorldWindow {
                     });
             });
             if world.update(&mut data) {
-                let address = 0x0003d800 + self.state.index * 32;
+                let address = 0x0003d800 + self.index * 32;
                 self.memory.write(self.sim_id, address as u32, &data);
             }
             if world.header.mode == WorldMode::HBias {
@@ -304,12 +290,10 @@ impl WorldWindow {
                                 });
                                 row.col(|ui| {
                                     let max = world.height.max(8) as usize;
-                                    ui.add(
-                                        NumberEdit::new(&mut self.state.param_index).range(0..max),
-                                    );
+                                    ui.add(NumberEdit::new(&mut self.param_index).range(0..max));
                                 });
                             });
-                            let base = (world.param_base + self.state.param_index * 2) & 0x1ffff;
+                            let base = (world.param_base + self.param_index * 2) & 0x1ffff;
                             let mut param = HBiasParam::load(&self.bgmaps.borrow(), base);
                             body.row(row_height, |mut row| {
                                 row.col(|ui| {
@@ -356,12 +340,10 @@ impl WorldWindow {
                                 });
                                 row.col(|ui| {
                                     let max = world.height.max(1) as usize;
-                                    ui.add(
-                                        NumberEdit::new(&mut self.state.param_index).range(0..max),
-                                    );
+                                    ui.add(NumberEdit::new(&mut self.param_index).range(0..max));
                                 });
                             });
-                            let base = (world.param_base + self.state.param_index * 8) & 0x1ffff;
+                            let base = (world.param_base + self.param_index * 8) & 0x1ffff;
                             let mut param = AffineParam::load(&self.bgmaps.borrow(), base);
                             body.row(row_height, |mut row| {
                                 row.col(|ui| {
@@ -421,49 +403,49 @@ impl WorldWindow {
                         });
                 });
             } else {
-                self.state.param_index = 0;
+                self.param_index = 0;
             }
             ui.section("Display", |ui| {
                 ui.horizontal(|ui| {
                     ui.label("Scale");
                     ui.spacing_mut().slider_width = ui.available_width();
-                    let slider = Slider::new(&mut self.state.scale, 1.0..=10.0)
+                    let slider = Slider::new(&mut self.scale, 1.0..=10.0)
                         .step_by(1.0)
                         .show_value(false);
                     ui.add(slider);
                 });
-                ui.checkbox(&mut self.state.generic_palette, "Generic palette");
-                ui.checkbox(&mut self.state.show_extents, "Show extents");
+                ui.checkbox(&mut self.generic_palette, "Generic palette");
+                ui.checkbox(&mut self.show_extents, "Show extents");
             });
         });
         self.params.write(WorldParams {
-            index: self.state.index,
-            generic_palette: self.state.generic_palette,
+            index: self.index,
+            generic_palette: self.generic_palette,
             ..*self.params
         });
     }
 
     fn show_world(&mut self, ui: &mut Ui) {
-        let image = Image::new(self.image_url("world"))
-            .fit_to_original_size(self.state.scale)
+        let image = Image::new("vip://world")
+            .fit_to_original_size(self.scale)
             .texture_options(TextureOptions::NEAREST);
         let res = ui.add(image);
-        if self.state.show_extents {
+        if self.show_extents {
             let world = {
                 let worlds = self.worlds.borrow();
-                let data = worlds.read(self.state.index);
+                let data = worlds.read(self.index);
                 World::parse(&data)
             };
             if world.header.mode == WorldMode::Object {
                 return;
             }
 
-            let lx1 = (world.dst_x - world.dst_parallax) as f32 * self.state.scale;
-            let lx2 = lx1 + world.width as f32 * self.state.scale;
-            let rx1 = (world.dst_x + world.dst_parallax) as f32 * self.state.scale;
-            let rx2 = rx1 + world.width as f32 * self.state.scale;
-            let y1 = world.dst_y as f32 * self.state.scale;
-            let y2 = y1 + world.height as f32 * self.state.scale;
+            let lx1 = (world.dst_x - world.dst_parallax) as f32 * self.scale;
+            let lx2 = lx1 + world.width as f32 * self.scale;
+            let rx1 = (world.dst_x + world.dst_parallax) as f32 * self.scale;
+            let rx2 = rx1 + world.width as f32 * self.scale;
+            let y1 = world.dst_y as f32 * self.scale;
+            let y2 = y1 + world.height as f32 * self.scale;
 
             let left_color = self.params.left_color;
             let right_color = self.params.right_color;
@@ -527,19 +509,26 @@ impl WorldWindow {
 }
 
 impl AppWindow for WorldWindow {
-    fn sim_id(&self) -> Option<SimId> {
-        Some(self.sim_id)
+    fn viewport_id(&self) -> ViewportId {
+        ViewportId::from_hash_of(format!("world-{}", self.sim_id))
+    }
+
+    fn sim_id(&self) -> SimId {
+        self.sim_id
     }
 
     fn initial_viewport(&self) -> ViewportBuilder {
         ViewportBuilder::default()
-            .with_title("Worlds")
+            .with_title(format!("Worlds ({})", self.sim_id))
             .with_inner_size((640.0, 520.0))
     }
 
-    fn show(&mut self, ui: &mut Ui) {
-        self.state.load(ui);
-        CentralPanel::default().show_inside(ui, |ui| {
+    fn on_init(&mut self, ctx: &Context, _render_state: &egui_wgpu::RenderState) {
+        ctx.add_texture_loader(self.loader.clone());
+    }
+
+    fn show(&mut self, ctx: &Context) {
+        CentralPanel::default().show(ctx, |ui| {
             ui.horizontal_top(|ui| {
                 StripBuilder::new(ui)
                     .size(Size::relative(0.3).at_most(200.0))
@@ -554,7 +543,6 @@ impl AppWindow for WorldWindow {
                     });
             });
         });
-        self.state.save(ui);
     }
 }
 
@@ -791,10 +779,6 @@ impl WorldRenderer {
 impl ImageRenderer<1> for WorldRenderer {
     type Params = WorldParams;
 
-    fn names(&self) -> [&str; 1] {
-        ["world"]
-    }
-
     fn sizes(&self) -> [[usize; 2]; 1] {
         [[384, 224]]
     }
@@ -1081,8 +1065,8 @@ impl<'a> SourceCoordCalculator<'a> {
                 (sx, sy)
             }
             SourceParam::Affine(affine) => {
-                let sx = affine_coord(affine.src_x, x, affine.dx, -(affine.src_parallax.min(0)));
-                let sy = affine_coord(affine.src_y, x, affine.dy, -(affine.src_parallax.min(0)));
+                let sx = affine_coord(affine.src_x, x, affine.dx, affine.src_parallax.min(0));
+                let sy = affine_coord(affine.src_y, x, affine.dy, affine.src_parallax.min(0));
                 (sx, sy)
             }
         }