PVB
/
shrooms-vb-core
2
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

Fix issues with H-Bias rendering #1

Open
SonicSwordcane wants to merge 1 commits from hbias-fix into main
pull from: hbias-fix
merge into: PVB:main
Conversation 0 Commits 1 Files Changed 1 +2 -2
SonicSwordcane commented 2025-08-15 03:54:37 +00:00
Owner
Copy Link

Fix two bugs with H-Bias rendering:

  • Increment h-bias parameter offset by 4 instead of 2 for each row drawn (the offset is in bytes, there are 4 bytes per row's hbias data)
  • Subtract HBias parameters from mx instead of adding them. The math works out.

Tested this on the title screen of Golf to confirm it was correct

Fix two bugs with H-Bias rendering: - Increment h-bias parameter offset by 4 instead of 2 for each row drawn (the offset is in bytes, there are 4 bytes per row's hbias data) - Subtract HBias parameters from `mx` instead of adding them. The math works out. Tested this on the title screen of Golf to confirm it was correct
SonicSwordcane added 1 commit 2025-08-15 03:54:38 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b hbias-fix main
git pull origin hbias-fix

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff hbias-fix
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PVB/shrooms-vb-core#1
No description provided.
Delete Branch "hbias-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?