PVB
/
shrooms-vb-core
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix handler address for FIV exception #2

Closed
SonicSwordcane wants to merge 0 commits from float-code-fix into main
pull from: float-code-fix
merge into: PVB:main
Conversation 3 Commits - Files Changed -
SonicSwordcane commented 2025-08-15 04:13:14 +00:00
Owner
Copy Link

Shrooms is invoking the wrong handler for "floating point invalid operation" exceptions. Fix a typo to make it correctly handle that special case.

Shrooms is invoking the wrong handler for "floating point invalid operation" exceptions. Fix a typo to make it correctly handle that special case.
SonicSwordcane added 1 commit 2025-08-15 04:13:15 +00:00
GuyPerfect commented 2025-08-17 18:25:12 +00:00
Owner
Copy Link

We were both wrong. See 531e4a8c3e for the correction.

We were both wrong. See [531e4a8c3e](https://git.virtual-boy.com/PVB/shrooms-vb-core/commit/531e4a8c3e245b340b2de7f21263abe43c598fa7) for the correction.
GuyPerfect closed this pull request 2025-08-17 18:25:12 +00:00
GuyPerfect commented 2025-08-17 18:29:50 +00:00
Owner
Copy Link

Turns out we weren't both wrong after all.

Turns out we weren't _both_ wrong after all.
GuyPerfect reopened this pull request 2025-08-17 18:29:50 +00:00
SonicSwordcane commented 2025-08-17 19:18:38 +00:00
Author
Owner
Copy Link

it's in main, so no need for a PR anymore

it's in main, so no need for a PR anymore
SonicSwordcane closed this pull request 2025-08-17 19:18:38 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PVB/shrooms-vb-core#2
No description provided.
Delete Branch "float-code-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?