Fix handler address for FIV exception #2

Closed

SonicSwordcane wants to merge 0 commits from float-code-fix into main

pull from: float-code-fix

merge into: :main

:main

:float-code-fix

Conversation 3 Commits - Files Changed -

SonicSwordcane commented 2025-08-15 04:13:14 +00:00

Owner

Copy Link

Copy Source

Shrooms is invoking the wrong handler for "floating point invalid operation" exceptions. Fix a typo to make it correctly handle that special case.

Shrooms is invoking the wrong handler for "floating point invalid operation" exceptions. Fix a typo to make it correctly handle that special case.

SonicSwordcane added 1 commit 2025-08-15 04:13:15 +00:00

Fix handler address for FIV exception 5d4a422e61

GuyPerfect commented 2025-08-17 18:25:12 +00:00

Owner

Copy Link

Copy Source

We were both wrong. See 531e4a8c3e for the correction.

We were both wrong. See [531e4a8c3e](https://git.virtual-boy.com/PVB/shrooms-vb-core/commit/531e4a8c3e245b340b2de7f21263abe43c598fa7) for the correction.

GuyPerfect closed this pull request 2025-08-17 18:25:12 +00:00

GuyPerfect commented 2025-08-17 18:29:50 +00:00

Owner

Copy Link

Copy Source

Turns out we weren't both wrong after all.

Turns out we weren't _both_ wrong after all.

GuyPerfect reopened this pull request 2025-08-17 18:29:50 +00:00

SonicSwordcane commented 2025-08-17 19:18:38 +00:00

Author

Owner

Copy Link

Copy Source

it's in main, so no need for a PR anymore

it's in main, so no need for a PR anymore

SonicSwordcane closed this pull request 2025-08-17 19:18:38 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GuyPerfect KR155E (Christian Radke) SonicSwordcane (Simon Gellis)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PVB/shrooms-vb-core#2