PVB
/
shrooms-vb-core
2
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

Add Floogle's latest audio fixes #3

Open
SonicSwordcane wants to merge 1 commits from floogle-audio-fixes into main
pull from: floogle-audio-fixes
merge into: PVB:main
Conversation 0 Commits 1 Files Changed 1 +21 -12
SonicSwordcane commented 2025-08-15 04:33:03 +00:00
Owner
Copy Link

Incorporate Floogle's latest batch of fixes to the VSU. In his words:

  • "the modmask on envelopes is cleared if you enable envelope repeat"
  • "if the volume is 0 and the envelope direction is down, even if the envelope is disabled, modmask is set"
  • "if at any point repeat is disabled, the envelope direction is down, and the reload value is 0, then modmask is super-set: enabling evelope repeat no longer clears it, only writing to SxINT will"

When I tested this, the two games with known audio issues (Virtual Fishing and SD Gundam) didn't sound any different. Neither did any of the other games I tested though (Red Alarm intro, Teleroboxing intro). We must have other audio bugs to flush out.

Incorporate Floogle's latest batch of fixes to the VSU. In his words: - "the modmask on envelopes is cleared if you enable envelope repeat" - "if the volume is 0 and the envelope direction is down, even if the envelope is disabled, modmask is set" - "if at any point repeat is disabled, the envelope direction is down, and the reload value is 0, then modmask is super-set: enabling evelope repeat no longer clears it, only writing to SxINT will" When I tested this, the two games with known audio issues (Virtual Fishing and SD Gundam) didn't sound any different. Neither did any of the other games I tested though (Red Alarm intro, Teleroboxing intro). We must have other audio bugs to flush out.
SonicSwordcane added 1 commit 2025-08-15 04:33:03 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b floogle-audio-fixes main
git pull origin floogle-audio-fixes

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff floogle-audio-fixes
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PVB/shrooms-vb-core#3
No description provided.
Delete Branch "floogle-audio-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?